Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: examples/java_android/echo/src/org/chromium/examples/java_echo/EchoServerApp.java

Issue 1169543002: Fix the API for ServiceFactoryBinder to be type safe. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: examples/java_android/echo/src/org/chromium/examples/java_echo/EchoServerApp.java
diff --git a/examples/java_android/echo/src/org/chromium/examples/java_echo/EchoServerApp.java b/examples/java_android/echo/src/org/chromium/examples/java_echo/EchoServerApp.java
index c4057d5cc0f29eaa5fe7d0a6ca94d8452b1ed330..9c2ac8e81cbf2a1af57c607ab84c718287a1207b 100644
--- a/examples/java_android/echo/src/org/chromium/examples/java_echo/EchoServerApp.java
+++ b/examples/java_android/echo/src/org/chromium/examples/java_echo/EchoServerApp.java
@@ -11,6 +11,7 @@ import org.chromium.mojo.application.ApplicationConnection;
import org.chromium.mojo.application.ApplicationDelegate;
import org.chromium.mojo.application.ApplicationRunner;
import org.chromium.mojo.application.ServiceFactoryBinder;
+import org.chromium.mojo.bindings.InterfaceRequest;
import org.chromium.mojo.examples.echo.Echo;
import org.chromium.mojo.system.Core;
import org.chromium.mojo.system.MessagePipeHandle;
@@ -21,8 +22,8 @@ import org.chromium.mojom.mojo.Shell;
* This is an example Java Mojo Application that receives a message from an echo client and then
* responds with that same message, prefixed by the string "Java EchoServer: ". The user does not
* directly request that this application be loaded. Instead the Mojo shell will load this
- * application when the echo client requests that an echo server be loaded. See the README.md
- * file for usage.
+ * application when the echo client requests that an echo server be loaded. See the README.md file
+ * for usage.
*/
class EchoServerApp implements ApplicationDelegate {
private static final String TAG = "JavaEchoServer";
@@ -55,8 +56,8 @@ class EchoServerApp implements ApplicationDelegate {
connection.addService(new ServiceFactoryBinder<Echo>() {
@Override
- public void bindNewInstanceToMessagePipe(MessagePipeHandle pipe) {
- Echo.MANAGER.bind(new EchoImpl(), pipe);
+ public void bind(InterfaceRequest<Echo> request) {
+ Echo.MANAGER.bind(new EchoImpl(), request);
}
@Override
@@ -73,8 +74,8 @@ class EchoServerApp implements ApplicationDelegate {
@Override
public void quit() {}
- public static void mojoMain(
- Context context, Core core, MessagePipeHandle applicationRequestHandle) {
+ public static void mojoMain(@SuppressWarnings("unused") Context context, Core core,
+ MessagePipeHandle applicationRequestHandle) {
ApplicationRunner.run(new EchoServerApp(), core, applicationRequestHandle);
}
}

Powered by Google App Engine
This is Rietveld 408576698