services/authentication/src/org/chromium/mojo/authentication/AuthenticationApp.java - Issue 1169543002: Fix the API for ServiceFactoryBinder to be type safe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/authentication/src/org/chromium/mojo/authentication/AuthenticationApp.java

Issue 1169543002: Fix the API for ServiceFactoryBinder to be type safe. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/java/bindings/src/org/chromium/mojo/bindings/InterfaceRequest.java ('k') | services/device_info/src/org/chromium/services/device_info/DeviceInfoService.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: services/authentication/src/org/chromium/mojo/authentication/AuthenticationApp.java

diff --git a/services/authentication/src/org/chromium/mojo/authentication/AuthenticationApp.java b/services/authentication/src/org/chromium/mojo/authentication/AuthenticationApp.java

index 3737648380773a3659f07402d5be94cd1987a369..7805807e6a9ff35861d7f7b32bd18589b970145f 100644

--- a/services/authentication/src/org/chromium/mojo/authentication/AuthenticationApp.java

+++ b/services/authentication/src/org/chromium/mojo/authentication/AuthenticationApp.java

@@ -10,6 +10,7 @@ import org.chromium.mojo.application.ApplicationConnection;

import org.chromium.mojo.application.ApplicationDelegate;

import org.chromium.mojo.application.ApplicationRunner;

import org.chromium.mojo.application.ServiceFactoryBinder;

+import org.chromium.mojo.bindings.InterfaceRequest;

import org.chromium.mojo.system.Core;

import org.chromium.mojo.system.MessagePipeHandle;

import org.chromium.mojom.mojo.Shell;

@@ -43,10 +44,10 @@ public class AuthenticationApp implements ApplicationDelegate {

connection.addService(new ServiceFactoryBinder<AuthenticationService>() {

@Override

- public void bindNewInstanceToMessagePipe(MessagePipeHandle pipe) {

+ public void bind(InterfaceRequest<AuthenticationService> request) {

AuthenticationService.MANAGER.bind(new AuthenticationServiceImpl(mContext, mCore,

connection.getRequestorUrl(), mShell),

- pipe);

+ request);

}

@Override