mojo/public/java/bindings/src/org/chromium/mojo/bindings/InterfaceRequest.java - Issue 1169543002: Fix the API for ServiceFactoryBinder to be type safe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/java/bindings/src/org/chromium/mojo/bindings/InterfaceRequest.java

Issue 1169543002: Fix the API for ServiceFactoryBinder to be type safe. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/java/application/src/org/chromium/mojo/application/ServiceFactoryBinder.java ('k') | services/authentication/src/org/chromium/mojo/authentication/AuthenticationApp.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/java/bindings/src/org/chromium/mojo/bindings/InterfaceRequest.java

diff --git a/mojo/public/java/bindings/src/org/chromium/mojo/bindings/InterfaceRequest.java b/mojo/public/java/bindings/src/org/chromium/mojo/bindings/InterfaceRequest.java

index 87835e0a788d1d9def14ffce92bec1419ffa6275..61899b446798a2057e0a5b215a4a4aec25af21d3 100644

--- a/mojo/public/java/bindings/src/org/chromium/mojo/bindings/InterfaceRequest.java

+++ b/mojo/public/java/bindings/src/org/chromium/mojo/bindings/InterfaceRequest.java

@@ -47,4 +47,12 @@ public class InterfaceRequest<P extends Interface> implements HandleOwner<Messag

mHandle.close();

}

+ /**

+ * Returns an {@link InterfaceRequest} that wraps the given handle. This method is not type safe

+ * and should be avoided unless absolutely necessary.

+ */

+ @SuppressWarnings("rawtypes")

+ public static InterfaceRequest asInterfaceRequestUnsafe(MessagePipeHandle handle) {

+ return new InterfaceRequest(handle);

+ }

}