Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1159)

Unified Diff: mojo/public/java/application/src/org/chromium/mojo/application/ApplicationConnection.java

Issue 1169543002: Fix the API for ServiceFactoryBinder to be type safe. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/java/application/src/org/chromium/mojo/application/ApplicationConnection.java
diff --git a/mojo/public/java/application/src/org/chromium/mojo/application/ApplicationConnection.java b/mojo/public/java/application/src/org/chromium/mojo/application/ApplicationConnection.java
index 6b0e5487d2bc51bafbde9926d57143368034ee05..9ccf8d1fde8c93a44899a2cf413573ed978ce0d5 100644
--- a/mojo/public/java/application/src/org/chromium/mojo/application/ApplicationConnection.java
+++ b/mojo/public/java/application/src/org/chromium/mojo/application/ApplicationConnection.java
@@ -5,6 +5,7 @@
package org.chromium.mojo.application;
import org.chromium.mojo.bindings.Interface;
+import org.chromium.mojo.bindings.InterfaceRequest;
import org.chromium.mojo.system.MessagePipeHandle;
import org.chromium.mojo.system.MojoException;
import org.chromium.mojom.mojo.ServiceProvider;
@@ -90,10 +91,12 @@ class ServiceProviderImpl implements ServiceProvider {
mNameToServiceMap.put(binder.getInterfaceName(), binder);
}
+ @SuppressWarnings("unchecked")
@Override
public void connectToService(String interfaceName, MessagePipeHandle pipe) {
if (mNameToServiceMap.containsKey(interfaceName)) {
- mNameToServiceMap.get(interfaceName).bindNewInstanceToMessagePipe(pipe);
+ mNameToServiceMap.get(interfaceName)
+ .bind(InterfaceRequest.asInterfaceRequestUnsafe(pipe));
} else {
pipe.close();
}
@@ -104,4 +107,4 @@ class ServiceProviderImpl implements ServiceProvider {
@Override
public void onConnectionError(MojoException e) {}
-}
+}

Powered by Google App Engine
This is Rietveld 408576698