Support variable changing in SDK interface and v8 native

Support variable changing in SDK interface and v8 native

Committed: http://code.google.com/p/chromedevtools/source/detail?r=1123

[Peter Rybin, 2013-01-09 19:37:13]

ping

[apavlov, 2013-01-10 13:59:20]

LGTM

https://codereview.chromium.org/11662019/diff/13001/plugins/org.chromium.sdk/...
File
plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/DebugSession.java
(right):

https://codereview.chromium.org/11662019/diff/13001/plugins/org.chromium.sdk/...
plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/DebugSession.java:307:
return new RelayOk() {
Just occurred to me. Why don't you keep a singleton instance for this?

[Peter Rybin, 2013-01-10 14:10:44]

https://codereview.chromium.org/11662019/diff/13001/plugins/org.chromium.sdk/...
File
plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/DebugSession.java
(right):

https://codereview.chromium.org/11662019/diff/13001/plugins/org.chromium.sdk/...
plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/DebugSession.java:307:
return new RelayOk() {
On 2013/01/10 13:59:20, apavlov wrote:
> Just occurred to me. Why don't you keep a singleton instance for this?

Mostly because I don't want to spoil outer namespace with a constant that is
never used (see fixed condition above).

[apavlov, 2013-01-10 14:16:12]

On 2013/01/10 14:10:44, Peter Rybin wrote:
>
https://codereview.chromium.org/11662019/diff/13001/plugins/org.chromium.sdk/...
> File
>
plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/DebugSession.java
> (right):
> 
>
https://codereview.chromium.org/11662019/diff/13001/plugins/org.chromium.sdk/...
>
plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/DebugSession.java:307:
> return new RelayOk() {
> On 2013/01/10 13:59:20, apavlov wrote:
> > Just occurred to me. Why don't you keep a singleton instance for this?
> 
> Mostly because I don't want to spoil outer namespace with a constant that is
> never used (see fixed condition above).

Not sure what you mean. I implied something like RelayOk.instance().

[Peter Rybin, 2013-01-10 14:28:48]

> Not sure what you mean. I implied something like RelayOk.instance().

This doesn't work like this. This value is of symbolical meaning. I have to
prove to myself and to everybody reading this that relay operation was finished
correctly. I make it in form of returning a token (that is never used on
runtime, but demanded by compiler). It's the comment inside that matters the
most.

[apavlov, 2013-01-10 14:42:07]

On 2013/01/10 14:28:48, Peter Rybin wrote:
> > Not sure what you mean. I implied something like RelayOk.instance().
> 
> This doesn't work like this. This value is of symbolical meaning. I have to
> prove to myself and to everybody reading this that relay operation was
finished
> correctly. I make it in form of returning a token (that is never used on
> runtime, but demanded by compiler). It's the comment inside that matters the
> most.

Yes, I remember its meaning, and since the actual token identity is never
checked, yet there may be lots and lots of similar tokens generated at runtime,
I thought it would be plausible to use a single token instance everywhere.