plugins/org.chromium.sdk.wipbackend.protocol_1_0/src/org/chromium/sdk/internal/wip/WipValueBuilder.java - Issue 11662019: Support variable changing in SDK interface and v8 native

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: plugins/org.chromium.sdk.wipbackend.protocol_1_0/src/org/chromium/sdk/internal/wip/WipValueBuilder.java

Issue 11662019: Support variable changing in SDK interface and v8 native (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk

Patch Set: merge Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipValueBuilder.java ('k') | plugins/org.chromium.sdk/src-dynamic-impl/parser/org/chromium/sdk/internal/v8native/protocol/input/V8DynamicParser.java » ('j') | plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/DebugSession.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: plugins/org.chromium.sdk.wipbackend.protocol_1_0/src/org/chromium/sdk/internal/wip/WipValueBuilder.java

diff --git a/plugins/org.chromium.sdk.wipbackend.protocol_1_0/src/org/chromium/sdk/internal/wip/WipValueBuilder.java b/plugins/org.chromium.sdk.wipbackend.protocol_1_0/src/org/chromium/sdk/internal/wip/WipValueBuilder.java

index b1bcdff4572302863ec3e7840ada42cec0cbfae0..fb8331149bb4329c3303ec429f8ced3328f1d9c1 100644

--- a/plugins/org.chromium.sdk.wipbackend.protocol_1_0/src/org/chromium/sdk/internal/wip/WipValueBuilder.java

+++ b/plugins/org.chromium.sdk.wipbackend.protocol_1_0/src/org/chromium/sdk/internal/wip/WipValueBuilder.java

@@ -668,8 +668,8 @@ class WipValueBuilder {

}

@Override

- public void setValue(String newValue, SetValueCallback callback)

- throws UnsupportedOperationException {

+ public RelayOk setValue(JsValue newValue, SetValueCallback callback,

+ SyncCallback syncCallback) throws UnsupportedOperationException {

throw new UnsupportedOperationException();

}