Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/ValueLoaderImpl.java

Issue 11662019: Support variable changing in SDK interface and v8 native (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk
Patch Set: merge Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/ValueLoaderImpl.java
diff --git a/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/ValueLoaderImpl.java b/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/ValueLoaderImpl.java
index d620f6919267355023f345258f63ef0132eb2ca8..e70668672254ded12a91a7f97efd0e07f1412e76 100644
--- a/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/ValueLoaderImpl.java
+++ b/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/ValueLoaderImpl.java
@@ -24,10 +24,10 @@ import org.chromium.sdk.internal.JsonUtil;
import org.chromium.sdk.internal.protocolparser.JsonProtocolParseException;
import org.chromium.sdk.internal.v8native.DebugSession;
import org.chromium.sdk.internal.v8native.InternalContext;
+import org.chromium.sdk.internal.v8native.InternalContext.ContextDismissedCheckedException;
import org.chromium.sdk.internal.v8native.V8BlockingCallback;
import org.chromium.sdk.internal.v8native.V8CommandCallbackBase;
import org.chromium.sdk.internal.v8native.V8Helper;
-import org.chromium.sdk.internal.v8native.InternalContext.ContextDismissedCheckedException;
import org.chromium.sdk.internal.v8native.protocol.input.FailedCommandResponse;
import org.chromium.sdk.internal.v8native.protocol.input.ScopeBody;
import org.chromium.sdk.internal.v8native.protocol.input.SuccessCommandResponse;
@@ -40,6 +40,7 @@ import org.chromium.sdk.internal.v8native.protocol.output.DebuggerMessage;
import org.chromium.sdk.internal.v8native.protocol.output.DebuggerMessageFactory;
import org.chromium.sdk.internal.v8native.protocol.output.EvaluateMessage;
import org.chromium.sdk.internal.v8native.protocol.output.LookupMessage;
+import org.chromium.sdk.internal.v8native.protocol.output.ScopeMessage;
import org.chromium.sdk.util.GenericCallback;
import org.chromium.sdk.util.MethodIsBlockingException;
import org.json.simple.JSONObject;
@@ -183,9 +184,9 @@ public class ValueLoaderImpl extends ValueLoader {
/**
* Looks up data for scope on remote in form of scope object handle.
*/
- public ObjectValueHandle loadScopeFields(int scopeNumber,
- DebuggerMessageFactory.ScopeHostParameter host) throws MethodIsBlockingException {
- DebuggerMessage message = DebuggerMessageFactory.scope(scopeNumber, host);
+ public ObjectValueHandle loadScopeFields(ScopeMessage.Ref scopeRef)
+ throws MethodIsBlockingException {
+ DebuggerMessage message = new ScopeMessage(scopeRef);
V8BlockingCallback<ObjectValueHandle> callback = new V8BlockingCallback<ObjectValueHandle>() {
@Override

Powered by Google App Engine
This is Rietveld 408576698