plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/CallFrameImpl.java - Issue 11662019: Support variable changing in SDK interface and v8 native

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/CallFrameImpl.java

Issue 11662019: Support variable changing in SDK interface and v8 native (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk

Patch Set: merge Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « plugins/org.chromium.sdk/src/org/chromium/sdk/JsVariable.java ('k') | plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/ContextBuilder.java » ('j') | plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/DebugSession.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/CallFrameImpl.java

diff --git a/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/CallFrameImpl.java b/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/CallFrameImpl.java

index 7d116365f44509e130b4c52cd13437e5ee78d883..37fb95172062462bbd42245fd52c4dce7c55323f 100755

--- a/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/CallFrameImpl.java

+++ b/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/CallFrameImpl.java

@@ -167,7 +167,8 @@ public class CallFrameImpl implements CallFrame {

valueLoader.getOrLoadValueFromRefs(Collections.singletonList(ref)).get(0);

// This name should be string. We are making it string as a fall-back strategy.

String varNameStr = ref.getName().toString();

- result = new JsVariableBase.Impl(valueLoader, mirror, varNameStr);

+ // 'this' variable is not mutable. Consider making it mutable.

+ result = new JsVariableBase.Impl(null, valueLoader, mirror, varNameStr);

}

if (result != null) {

receiverVariableRef.compareAndSet(null, result);