Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1781)

Unified Diff: plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/DebugSession.java

Issue 11662019: Support variable changing in SDK interface and v8 native (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk
Patch Set: merge Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/DebugSession.java
diff --git a/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/DebugSession.java b/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/DebugSession.java
index ed64a81b395b785c96b0bc6d32420b2138ad98a5..081af9abf00154bd25219819067ebfd249c790a0 100755
--- a/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/DebugSession.java
+++ b/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/DebugSession.java
@@ -293,4 +293,20 @@ public class DebugSession {
throw new InvalidContextException(e);
}
}
+
+ public RelayOk maybeRethrowContextException(ContextDismissedCheckedException e,
+ SyncCallback syncCallback) {
+ // TODO(peter.rybin): make some kind of option out of this
+ final boolean strictPolicy = true;
+ if (strictPolicy) {
+ throw new InvalidContextException(e);
+ } else {
+ if (syncCallback != null) {
+ syncCallback.callbackDone(new InvalidContextException(e));
+ }
+ return new RelayOk() {
apavlov 2013/01/10 13:59:20 Just occurred to me. Why don't you keep a singleto
Peter Rybin 2013/01/10 14:10:44 Mostly because I don't want to spoil outer namespa
+ // It's ok, we called SyncCallback alright.
+ };
+ }
+ }
}

Powered by Google App Engine
This is Rietveld 408576698