Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 1159323003: Credential Management: Rename 'notifySignedOut' to 'requireUserMediation' (2/3) (Closed)

Created:
5 years, 6 months ago by Mike West
Modified:
5 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, gcasto+watchlist_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mkwst+moarreviews-shell_chromium.org, mkwst+watchlist-passwords_chromium.org, mlamouri+watch-content_chromium.org, vabr+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@rename-password
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Credential Management: Rename 'notifySignedOut' to 'requireUserMediation' (2/3) As per https://w3c.github.io/webappsec/specs/credentialmanagement/#dom-credentialcontainer-requireusermediation Patch 1 (Blink): https://codereview.chromium.org/1160283002 Patch 2 (Chromium): [This patch] Patch 3 (Blink): https://codereview.chromium.org/1204933004 BUG=494880 R=vabr@chromium.org,jochen@chromium.org NOPRESUBMIT=true Committed: https://crrev.com/47601e708062571a54185905fa73e9eb69330d03 Cr-Commit-Position: refs/heads/master@{#336163}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -181 lines) Patch
M components/password_manager.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M components/password_manager/content/browser/credential_manager_dispatcher.h View 1 5 chunks +7 lines, -6 lines 0 comments Download
M components/password_manager/content/browser/credential_manager_dispatcher.cc View 1 3 chunks +14 lines, -13 lines 0 comments Download
M components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
M components/password_manager/content/common/credential_manager_messages.h View 2 chunks +7 lines, -7 lines 0 comments Download
M components/password_manager/content/renderer/credential_manager_client.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/password_manager/content/renderer/credential_manager_client.cc View 4 chunks +10 lines, -8 lines 0 comments Download
M components/password_manager/content/renderer/credential_manager_client_browsertest.cc View 1 2 chunks +9 lines, -9 lines 0 comments Download
M components/password_manager/core/browser/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/password_manager/core/browser/credential_manager_pending_require_user_mediation_task.h View 3 chunks +17 lines, -15 lines 0 comments Download
A + components/password_manager/core/browser/credential_manager_pending_require_user_mediation_task.cc View 3 chunks +12 lines, -10 lines 0 comments Download
D components/password_manager/core/browser/credential_manager_pending_signed_out_task.h View 1 chunk +0 lines, -58 lines 0 comments Download
D components/password_manager/core/browser/credential_manager_pending_signed_out_task.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M components/test_runner/mock_credential_manager_client.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/test_runner/mock_credential_manager_client.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
Mike West
more (2/3)
5 years, 6 months ago (2015-06-01 10:46:10 UTC) #1
vabr (Chromium)
lgtm
5 years, 6 months ago (2015-06-01 11:47:14 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-01 13:35:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159323003/20001
5 years, 6 months ago (2015-06-25 12:25:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/73937)
5 years, 6 months ago (2015-06-25 12:32:03 UTC) #8
Mike West
On 2015/06/25 at 12:32:03, commit-bot wrote: > Try jobs failed on following builders: > chromium_presubmit ...
5 years, 6 months ago (2015-06-25 15:13:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159323003/20001
5 years, 6 months ago (2015-06-25 15:15:16 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-25 15:38:24 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-25 15:39:51 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/47601e708062571a54185905fa73e9eb69330d03
Cr-Commit-Position: refs/heads/master@{#336163}

Powered by Google App Engine
This is Rietveld 408576698