components/password_manager/content/common/credential_manager_messages.h - Issue 1159323003: Credential Management: Rename 'notifySignedOut' to 'requireUserMediation' (2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/common/credential_manager_messages.h

Issue 1159323003: Credential Management: Rename 'notifySignedOut' to 'requireUserMediation' (2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rename-password

Patch Set: Rebase. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc ('k') | components/password_manager/content/renderer/credential_manager_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/common/credential_manager_messages.h

diff --git a/components/password_manager/content/common/credential_manager_messages.h b/components/password_manager/content/common/credential_manager_messages.h

index 32ee1e477b4b82395fc2e8d192449cd7b46ced8d..9cb485f58e83f8b2c17715fce906b44d2ea37bc8 100644

--- a/components/password_manager/content/common/credential_manager_messages.h

+++ b/components/password_manager/content/common/credential_manager_messages.h

@@ -54,11 +54,11 @@ IPC_MESSAGE_ROUTED2(CredentialManagerHostMsg_NotifySignedIn,

int /* request_id */,

password_manager::CredentialInfo /* credential */)

-// Passes the notification from 'navigator.credentials.notifySignedOut()' up to

-// the browser process in order to clear the "zeroclick" bit on that origin's

-// stored credentials. The browser process will respond with a

-// CredentialManagerMsg_AcknowledgeSignedOut message.

-IPC_MESSAGE_ROUTED1(CredentialManagerHostMsg_NotifySignedOut,

+// Passes the notification from 'navigator.credentials.requireUserMediation()'

+// up to the browser process in order to clear the "zeroclick" bit on that

+// origin's stored credentials. The browser process will respond with a

+// CredentialManagerMsg_AcknowledgeRequireUserMediation message.

+IPC_MESSAGE_ROUTED1(CredentialManagerHostMsg_RequireUserMediation,

int /* request_id */)

// Requests a credential from the browser process in response to a page calling

@@ -83,8 +83,8 @@ IPC_MESSAGE_ROUTED1(CredentialManagerMsg_AcknowledgeSignedIn,

int /* request_id */)

// Notify the renderer that the browser process has finished processing a

-// CredentialManagerHostMsg_NotifySignedOut message.

-IPC_MESSAGE_ROUTED1(CredentialManagerMsg_AcknowledgeSignedOut,

+// CredentialManagerHostMsg_RequireUserMediation message.

+IPC_MESSAGE_ROUTED1(CredentialManagerMsg_AcknowledgeRequireUserMediation,

int /* request_id */)

// Send a credential to the renderer in response to a