components/password_manager/content/renderer/credential_manager_client.h - Issue 1159323003: Credential Management: Rename 'notifySignedOut' to 'requireUserMediation' (2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/renderer/credential_manager_client.h

Issue 1159323003: Credential Management: Rename 'notifySignedOut' to 'requireUserMediation' (2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rename-password

Patch Set: Rebase. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/common/credential_manager_messages.h ('k') | components/password_manager/content/renderer/credential_manager_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/renderer/credential_manager_client.h

diff --git a/components/password_manager/content/renderer/credential_manager_client.h b/components/password_manager/content/renderer/credential_manager_client.h

index a2888ee0f9294b1532bdbde886fde1db394d7109..c854636d5761232a3371c4beee7f782e3d8e5821 100644

--- a/components/password_manager/content/renderer/credential_manager_client.h

+++ b/components/password_manager/content/renderer/credential_manager_client.h

@@ -56,7 +56,7 @@ class CredentialManagerClient : public blink::WebCredentialManagerClient,

// Message handlers for messages from the browser process:

virtual void OnAcknowledgeFailedSignIn(int request_id);

virtual void OnAcknowledgeSignedIn(int request_id);

- virtual void OnAcknowledgeSignedOut(int request_id);

+ virtual void OnAcknowledgeRequireUserMediation(int request_id);

virtual void OnSendCredential(int request_id,

const CredentialInfo& credential_info);

virtual void OnRejectCredentialRequest(

@@ -70,7 +70,7 @@ class CredentialManagerClient : public blink::WebCredentialManagerClient,

virtual void dispatchSignedIn(

const blink::WebCredential& credential,

WebCredentialManagerClient::NotificationCallbacks* callbacks);

- virtual void dispatchSignedOut(NotificationCallbacks* callbacks);

+ virtual void dispatchRequireUserMediation(NotificationCallbacks* callbacks);

virtual void dispatchRequest(

bool zero_click_only,

const blink::WebVector<blink::WebURL>& federations,

@@ -89,7 +89,7 @@ class CredentialManagerClient : public blink::WebCredentialManagerClient,

// generated from Blink. This class takes ownership of these objects.

NotificationCallbacksMap failed_sign_in_callbacks_;

NotificationCallbacksMap signed_in_callbacks_;

- NotificationCallbacksMap signed_out_callbacks_;

+ NotificationCallbacksMap require_user_mediation_callbacks_;

RequestCallbacksMap request_callbacks_;

DISALLOW_COPY_AND_ASSIGN(CredentialManagerClient);