Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: components/password_manager/content/browser/credential_manager_dispatcher.h

Issue 1159323003: Credential Management: Rename 'notifySignedOut' to 'requireUserMediation' (2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rename-password
Patch Set: Rebase. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/content/browser/credential_manager_dispatcher.h
diff --git a/components/password_manager/content/browser/credential_manager_dispatcher.h b/components/password_manager/content/browser/credential_manager_dispatcher.h
index 1af6a1aa19435dcfbea948ebc94879d51fc71bd5..1ab038d5e7e84b07f72fb082518181d233f4df7b 100644
--- a/components/password_manager/content/browser/credential_manager_dispatcher.h
+++ b/components/password_manager/content/browser/credential_manager_dispatcher.h
@@ -12,7 +12,7 @@
#include "base/prefs/pref_member.h"
#include "components/password_manager/core/browser/credential_manager_password_form_manager.h"
#include "components/password_manager/core/browser/credential_manager_pending_request_task.h"
-#include "components/password_manager/core/browser/credential_manager_pending_signed_out_task.h"
+#include "components/password_manager/core/browser/credential_manager_pending_require_user_mediation_task.h"
#include "components/password_manager/core/browser/password_store_consumer.h"
#include "content/public/browser/web_contents_observer.h"
@@ -37,7 +37,7 @@ class CredentialManagerDispatcher
: public content::WebContentsObserver,
public CredentialManagerPasswordFormManagerDelegate,
public CredentialManagerPendingRequestTaskDelegate,
- public CredentialManagerPendingSignedOutTaskDelegate {
+ public CredentialManagerPendingRequireUserMediationTaskDelegate {
public:
CredentialManagerDispatcher(content::WebContents* web_contents,
PasswordManagerClient* client);
@@ -54,8 +54,8 @@ class CredentialManagerDispatcher
const password_manager::CredentialInfo&);
// Called in response to an IPC from the renderer, triggered by a page's call
- // to 'navigator.credentials.notifySignedOut'.
- virtual void OnNotifySignedOut(int request_id);
+ // to 'navigator.credentials.requireUserMediation'.
+ virtual void OnRequireUserMediation(int request_id);
// Called in response to an IPC from the renderer, triggered by a page's call
// to 'navigator.credentials.request'.
@@ -80,7 +80,7 @@ class CredentialManagerDispatcher
// CredentialManagerPendingSignedOutTaskDelegate:
PasswordStore* GetPasswordStore() override;
- void DoneSigningOut() override;
+ void DoneRequiringUserMediation() override;
// CredentialManagerPasswordFormManagerDelegate:
void OnProvisionalSaveComplete() override;
@@ -101,7 +101,8 @@ class CredentialManagerDispatcher
// they can properly respond to the request once the PasswordStore gives
// us data.
scoped_ptr<CredentialManagerPendingRequestTask> pending_request_;
- scoped_ptr<CredentialManagerPendingSignedOutTask> pending_sign_out_;
+ scoped_ptr<CredentialManagerPendingRequireUserMediationTask>
+ pending_require_user_mediation_;
DISALLOW_COPY_AND_ASSIGN(CredentialManagerDispatcher);
};
« no previous file with comments | « components/password_manager.gypi ('k') | components/password_manager/content/browser/credential_manager_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698