Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Unified Diff: components/password_manager/content/renderer/credential_manager_client.cc

Issue 1159323003: Credential Management: Rename 'notifySignedOut' to 'requireUserMediation' (2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rename-password
Patch Set: Rebase. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/content/renderer/credential_manager_client.cc
diff --git a/components/password_manager/content/renderer/credential_manager_client.cc b/components/password_manager/content/renderer/credential_manager_client.cc
index 66754a7bcc82d35f70743f5f57041d42aa501786..03b17a09f5275d6f2de883d237575e3c9d41b3de 100644
--- a/components/password_manager/content/renderer/credential_manager_client.cc
+++ b/components/password_manager/content/renderer/credential_manager_client.cc
@@ -41,7 +41,7 @@ CredentialManagerClient::CredentialManagerClient(
CredentialManagerClient::~CredentialManagerClient() {
ClearCallbacksMapWithErrors(&failed_sign_in_callbacks_);
ClearCallbacksMapWithErrors(&signed_in_callbacks_);
- ClearCallbacksMapWithErrors(&signed_out_callbacks_);
+ ClearCallbacksMapWithErrors(&require_user_mediation_callbacks_);
ClearCallbacksMapWithErrors(&request_callbacks_);
}
@@ -55,8 +55,8 @@ bool CredentialManagerClient::OnMessageReceived(const IPC::Message& message) {
OnAcknowledgeFailedSignIn)
IPC_MESSAGE_HANDLER(CredentialManagerMsg_AcknowledgeSignedIn,
OnAcknowledgeSignedIn)
- IPC_MESSAGE_HANDLER(CredentialManagerMsg_AcknowledgeSignedOut,
- OnAcknowledgeSignedOut)
+ IPC_MESSAGE_HANDLER(CredentialManagerMsg_AcknowledgeRequireUserMediation,
+ OnAcknowledgeRequireUserMediation)
IPC_MESSAGE_HANDLER(CredentialManagerMsg_SendCredential, OnSendCredential)
IPC_MESSAGE_HANDLER(CredentialManagerMsg_RejectCredentialRequest,
OnRejectCredentialRequest)
@@ -73,8 +73,9 @@ void CredentialManagerClient::OnAcknowledgeSignedIn(int request_id) {
RespondToNotificationCallback(request_id, &signed_in_callbacks_);
}
-void CredentialManagerClient::OnAcknowledgeSignedOut(int request_id) {
- RespondToNotificationCallback(request_id, &signed_out_callbacks_);
+void CredentialManagerClient::OnAcknowledgeRequireUserMediation(
+ int request_id) {
+ RespondToNotificationCallback(request_id, &require_user_mediation_callbacks_);
}
void CredentialManagerClient::OnSendCredential(int request_id,
@@ -131,10 +132,11 @@ void CredentialManagerClient::dispatchSignedIn(
routing_id(), request_id, info));
}
-void CredentialManagerClient::dispatchSignedOut(
+void CredentialManagerClient::dispatchRequireUserMediation(
NotificationCallbacks* callbacks) {
- int request_id = signed_out_callbacks_.Add(callbacks);
- Send(new CredentialManagerHostMsg_NotifySignedOut(routing_id(), request_id));
+ int request_id = require_user_mediation_callbacks_.Add(callbacks);
+ Send(new CredentialManagerHostMsg_RequireUserMediation(routing_id(),
+ request_id));
}
void CredentialManagerClient::dispatchRequest(

Powered by Google App Engine
This is Rietveld 408576698