Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Unified Diff: components/password_manager/core/browser/credential_manager_pending_require_user_mediation_task.h

Issue 1159323003: Credential Management: Rename 'notifySignedOut' to 'requireUserMediation' (2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rename-password
Patch Set: Rebase. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/credential_manager_pending_require_user_mediation_task.h
diff --git a/components/password_manager/core/browser/credential_manager_pending_signed_out_task.h b/components/password_manager/core/browser/credential_manager_pending_require_user_mediation_task.h
similarity index 52%
rename from components/password_manager/core/browser/credential_manager_pending_signed_out_task.h
rename to components/password_manager/core/browser/credential_manager_pending_require_user_mediation_task.h
index 5012e0d1e0671e1a3dc99b31bd6e88a76a13e4e3..5aa129ea6132b2e49816390a3b84b4ff165dccb8 100644
--- a/components/password_manager/core/browser/credential_manager_pending_signed_out_task.h
+++ b/components/password_manager/core/browser/credential_manager_pending_require_user_mediation_task.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_CREDENTIAL_MANAGER_PENDING_SIGNED_OUT_TASK_H_
-#define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_CREDENTIAL_MANAGER_PENDING_SIGNED_OUT_TASK_H_
+#ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_CREDENTIAL_MANAGER_PENDING_REQUIRE_USER_MEDIATION_TASK_H_
+#define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_CREDENTIAL_MANAGER_PENDING_REQUIRE_USER_MEDIATION_TASK_H_
#include <set>
#include <string>
@@ -21,25 +21,26 @@ namespace password_manager {
class PasswordStore;
-// Handles sign-out completion and retrieves embedder-dependent services.
-class CredentialManagerPendingSignedOutTaskDelegate {
+// Handles mediation completion and retrieves embedder-dependent services.
+class CredentialManagerPendingRequireUserMediationTaskDelegate {
public:
// Retrieves the PasswordStore.
virtual PasswordStore* GetPasswordStore() = 0;
- // Finishes sign-out tasks.
- virtual void DoneSigningOut() = 0;
+ // Finishes mediation tasks.
+ virtual void DoneRequiringUserMediation() = 0;
};
-// Notifies the password store that a list of origins have been signed out.
-class CredentialManagerPendingSignedOutTask : public PasswordStoreConsumer {
+// Notifies the password store that a list of origins require user mediation.
+class CredentialManagerPendingRequireUserMediationTask
+ : public PasswordStoreConsumer {
public:
- CredentialManagerPendingSignedOutTask(
- CredentialManagerPendingSignedOutTaskDelegate* delegate,
+ CredentialManagerPendingRequireUserMediationTask(
+ CredentialManagerPendingRequireUserMediationTaskDelegate* delegate,
const GURL& origin);
- ~CredentialManagerPendingSignedOutTask() override;
+ ~CredentialManagerPendingRequireUserMediationTask() override;
- // Adds an origin to be signed out.
+ // Adds an origin to require user mediation.
void AddOrigin(const GURL& origin);
// PasswordStoreConsumer implementation.
@@ -47,12 +48,13 @@ class CredentialManagerPendingSignedOutTask : public PasswordStoreConsumer {
ScopedVector<autofill::PasswordForm> results) override;
private:
- CredentialManagerPendingSignedOutTaskDelegate* const delegate_; // Weak.
+ CredentialManagerPendingRequireUserMediationTaskDelegate* const
+ delegate_; // Weak.
std::set<std::string> origins_;
- DISALLOW_COPY_AND_ASSIGN(CredentialManagerPendingSignedOutTask);
+ DISALLOW_COPY_AND_ASSIGN(CredentialManagerPendingRequireUserMediationTask);
};
} // namespace password_manager
-#endif // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_CREDENTIAL_MANAGER_PENDING_SIGNED_OUT_TASK_H_
+#endif // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_CREDENTIAL_MANAGER_PENDING_REQUIRE_USER_MEDIATION_TASK_H_

Powered by Google App Engine
This is Rietveld 408576698