Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Issue 1156273006: Remove unused code calling WebMediaPlayerClient::requestFullscreen() (Closed)

Created:
5 years, 6 months ago by philipj_slow
Modified:
5 years, 6 months ago
Reviewers:
Mike West, qinmin, xhwang
CC:
avayvod+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, ddorwin, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-media_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused code calling WebMediaPlayerClient::requestFullscreen() This was used for a while and then removed again: https://codereview.chromium.org/41123002 https://codereview.chromium.org/1021723003 BUG=496627 Committed: https://crrev.com/8456c96c8ddcb13363cdbd3a7112d8aa9cf1967e Cr-Commit-Position: refs/heads/master@{#334132}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -36 lines) Patch
M content/browser/media/android/browser_media_player_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/media/android/browser_media_player_manager.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M content/common/media/media_player_messages_android.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/media/android/renderer_media_player_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/android/renderer_media_player_manager.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M media/base/android/media_player_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M media/base/android/media_source_player_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (5 generated)
philipj_slow
PTAL. I've successfully built chrome_public_apk with this change so unless there's non-public code this really ...
5 years, 6 months ago (2015-06-04 11:08:24 UTC) #2
xhwang
On 2015/06/04 11:08:24, philipj wrote: > PTAL. I've successfully built chrome_public_apk with this change so ...
5 years, 6 months ago (2015-06-11 16:14:57 UTC) #3
xhwang
cc ddorwin: FYI I meant lgtm from me. But you need qinmin's approval as well ...
5 years, 6 months ago (2015-06-11 16:19:32 UTC) #4
qinmin
lgtm
5 years, 6 months ago (2015-06-11 19:16:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156273006/1
5 years, 6 months ago (2015-06-11 19:32:25 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/70269)
5 years, 6 months ago (2015-06-11 19:43:08 UTC) #9
philipj_slow
mkwst@, owners review for content/common/media/media_player_messages_android.h please? :)
5 years, 6 months ago (2015-06-11 19:46:48 UTC) #11
Mike West
Removing messages _always_ LGTM. :)
5 years, 6 months ago (2015-06-12 07:28:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156273006/1
5 years, 6 months ago (2015-06-12 07:38:36 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-12 07:42:10 UTC) #15
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 07:42:55 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8456c96c8ddcb13363cdbd3a7112d8aa9cf1967e
Cr-Commit-Position: refs/heads/master@{#334132}

Powered by Google App Engine
This is Rietveld 408576698