content/renderer/media/android/renderer_media_player_manager.cc - Issue 1156273006: Remove unused code calling WebMediaPlayerClient::requestFullscreen()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/android/renderer_media_player_manager.cc

Issue 1156273006: Remove unused code calling WebMediaPlayerClient::requestFullscreen() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/android/renderer_media_player_manager.h ('k') | content/renderer/media/android/webmediaplayer_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/android/renderer_media_player_manager.cc

diff --git a/content/renderer/media/android/renderer_media_player_manager.cc b/content/renderer/media/android/renderer_media_player_manager.cc

index 9957ced350cdf81b21ae6ab4aaf77c3074cd2ed3..ad154d665f03e35550084de85313d6777f0afb42 100644

--- a/content/renderer/media/android/renderer_media_player_manager.cc

+++ b/content/renderer/media/android/renderer_media_player_manager.cc

@@ -50,8 +50,6 @@ bool RendererMediaPlayerManager::OnMessageReceived(const IPC::Message& msg) {

OnConnectedToRemoteDevice)

IPC_MESSAGE_HANDLER(MediaPlayerMsg_DisconnectedFromRemoteDevice,

OnDisconnectedFromRemoteDevice)

- IPC_MESSAGE_HANDLER(MediaPlayerMsg_RequestFullscreen,

- OnRequestFullscreen)

IPC_MESSAGE_HANDLER(MediaPlayerMsg_DidExitFullscreen, OnDidExitFullscreen)

IPC_MESSAGE_HANDLER(MediaPlayerMsg_DidMediaPlayerPlay, OnPlayerPlay)

IPC_MESSAGE_HANDLER(MediaPlayerMsg_DidMediaPlayerPause, OnPlayerPause)

@@ -234,12 +232,6 @@ void RendererMediaPlayerManager::OnPlayerPause(int player_id) {

player->OnMediaPlayerPause();

}

-void RendererMediaPlayerManager::OnRequestFullscreen(int player_id) {

- WebMediaPlayerAndroid* player = GetMediaPlayer(player_id);

- if (player)

- player->OnRequestFullscreen();

void RendererMediaPlayerManager::OnRemoteRouteAvailabilityChanged(

int player_id,

bool routes_available) {