Request video element to enter fullscreen when playing protected content

Request video element to enter fullscreen when playing protected content

This CL sends an IPC to the render process to request the video element to enter fullscreen.
Compared to the old approach, this is more compatible with the upcoming new fullscreen mode, which webkit uses FS API for fullscreen.
Currently we need the disable-gesture-requirement-for-fullscreen-media-playback flag for this to work. May consider making the flag default on android.

BUG=262945
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234725

[qinmin, 2013-10-24 18:40:53]

PTAL

[xhwang, 2013-10-25 18:21:59]

LG but I don't fully understand how everything works. Please see the question.

https://codereview.chromium.org/41123002/diff/1/content/browser/media/android...
File content/browser/media/android/browser_media_player_manager.cc (right):

https://codereview.chromium.org/41123002/diff/1/content/browser/media/android...
content/browser/media/android/browser_media_player_manager.cc:335: }
newbie question: How is this related to OnEnterFullscreen on l.403? Also we have
DisableFullscreenEncryptedMediaPlayback(). Can we have some doc/notes about how
the fullscreen workflow works in different scenarios?

https://codereview.chromium.org/41123002/diff/1/content/common/media/media_pl...
File content/common/media/media_player_messages_android.h (right):

https://codereview.chromium.org/41123002/diff/1/content/common/media/media_pl...
content/common/media/media_player_messages_android.h:259: 
why extra line?

[qinmin, 2013-10-25 20:06:12]

https://codereview.chromium.org/41123002/diff/1/content/browser/media/android...
File content/browser/media/android/browser_media_player_manager.cc (right):

https://codereview.chromium.org/41123002/diff/1/content/browser/media/android...
content/browser/media/android/browser_media_player_manager.cc:335: }
So when this IPC gets sent to the render process, it allows blink go through all
the renderFullscreen code path to make sure we are using the correct rendering
mode for the video. And onEnterFullscreen() will be called afterwards.

DisableFullscreenEncryptedMediaPlayback() is a temporary thing. If it is called
before OnEnterFullscreen(), we will wait until GenerateKeyIfAllowed() to retry
the whole fullscreen logic. If it is called after OnEnterFullscreen(), then the
player will enter fullscreen first, and then quit afterwards.

updated the comments above.
On 2013/10/25 18:21:59, xhwang wrote:
> newbie question: How is this related to OnEnterFullscreen on l.403? Also we
have
> DisableFullscreenEncryptedMediaPlayback(). Can we have some doc/notes about
how
> the fullscreen workflow works in different scenarios?

[xhwang, 2013-10-25 20:27:49]

lgtm, thanks for the explanation!

[commit-bot: I haz the power, 2013-10-25 22:08:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qinmin@chromium.org/41123002/70001

[commit-bot: I haz the power, 2013-10-25 22:26:33]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[qinmin, 2013-10-25 23:41:05]

+jschuh for IPC owner

[qinmin, 2013-10-29 21:45:59]

Hi, Justin, would you please take a look at media_player_messages_android.h? 

Thanks

[jschuh, 2013-10-29 22:35:19]

ipc security lgtm

[commit-bot: I haz the power, 2013-10-29 22:56:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qinmin@chromium.org/41123002/70001

[commit-bot: I haz the power, 2013-10-29 23:14:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qinmin@chromium.org/41123002/70001

[commit-bot: I haz the power, 2013-10-30 03:05:57]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-10-30 03:20:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qinmin@chromium.org/41123002/70001

[commit-bot: I haz the power, 2013-10-30 07:44:26]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-11-11 23:01:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qinmin@chromium.org/41123002/490001

[commit-bot: I haz the power, 2013-11-12 23:29:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qinmin@chromium.org/41123002/490001

[commit-bot: I haz the power, 2013-11-13 01:40:26]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-11-13 01:55:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qinmin@chromium.org/41123002/490001

[commit-bot: I haz the power, 2013-11-13 03:28:55]

Change committed as 234725