Android: Never automatically enter fullscreen when media playback starts.

Android: Never automatically enter fullscreen when media playback starts.

Previously, the media player would automatically enter fullscreen when a
protected surface is required and hole-punching is not enabled.
This behavior is inconsistent with all other scenarios.

This is mostly a revert of r282588 (7d930ce), which disabled the automatic
behavior when hole-punching is enabled.
The other change is to remove the automatic behavior altogether.

The original automatic behavior was added to MediaPlayerManagerImpl in r210114.

BUG=459416
Committed: https://crrev.com/a1a3db25697c8cbc046a77a0c0a4e706f7f31be6
Cr-Commit-Position: refs/heads/master@{#321668}

[ddorwin, 2015-03-19 23:23:05]

ddorwin@chromium.org changed reviewers:
+ qinmin@chromium.org

[ddorwin, 2015-03-19 23:25:07]

ddorwin@chromium.org changed reviewers:
+ gunsch@chromium.org, xhwang@chromium.org

[ddorwin, 2015-03-19 23:25:07]

ddorwin@chromium.org changed required reviewers:
+ qinmin@chromium.org

[xhwang, 2015-03-20 18:07:45]

Thanks for the cleanup! Looking good in general but I think we can remove more
code.

https://codereview.chromium.org/1021723003/diff/1/content/browser/media/andro...
File content/browser/media/android/browser_media_player_manager.h (left):

https://codereview.chromium.org/1021723003/diff/1/content/browser/media/andro...
content/browser/media/android/browser_media_player_manager.h:100: bool
ShouldUseVideoOverlayForEmbeddedEncryptedVideo() override;
How about the renderer side? e.g.

https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/m...

https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/m...

https://codereview.chromium.org/1021723003/diff/1/media/base/android/media_so...
File media/base/android/media_source_player.cc (left):

https://codereview.chromium.org/1021723003/diff/1/media/base/android/media_so...
media/base/android/media_source_player.cc:124: bool request_fullscreen =
IsProtectedSurfaceRequired();
MediaSourcePlayer::IsProtectedSurfaceRequired() is not needed anymore.

[ddorwin, 2015-03-20 18:45:25]

qinmin: PTAL at  the discussion in browser_media_player_manager.h

https://codereview.chromium.org/1021723003/diff/1/content/browser/media/andro...
File content/browser/media/android/browser_media_player_manager.h (left):

https://codereview.chromium.org/1021723003/diff/1/content/browser/media/andro...
content/browser/media/android/browser_media_player_manager.h:100: bool
ShouldUseVideoOverlayForEmbeddedEncryptedVideo() override;
On 2015/03/20 18:07:44, xhwang wrote:
> How about the renderer side? e.g.
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/m...
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/m...

This appears to be related to getting a surface. Fullscreen is mentioned there,
but it's not clear that the reason is related to this.

qinmin@?

https://codereview.chromium.org/1021723003/diff/1/media/base/android/media_so...
File media/base/android/media_source_player.cc (left):

https://codereview.chromium.org/1021723003/diff/1/media/base/android/media_so...
media/base/android/media_source_player.cc:124: bool request_fullscreen =
IsProtectedSurfaceRequired();
On 2015/03/20 18:07:44, xhwang wrote:
> MediaSourcePlayer::IsProtectedSurfaceRequired() is not needed anymore.

Done. Thanks.

[qinmin, 2015-03-20 19:47:46]

https://codereview.chromium.org/1021723003/diff/1/content/browser/media/andro...
File content/browser/media/android/browser_media_player_manager.h (left):

https://codereview.chromium.org/1021723003/diff/1/content/browser/media/andro...
content/browser/media/android/browser_media_player_manager.h:100: bool
ShouldUseVideoOverlayForEmbeddedEncryptedVideo() override;
This surface is for hole punching and probably we don't want to remove it. TV
uses this to show L1 video for non-fullscreen mode

On 2015/03/20 18:45:25, ddorwin wrote:
> On 2015/03/20 18:07:44, xhwang wrote:
> > How about the renderer side? e.g.
> > 
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/m...
> > 
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/m...
> 
> This appears to be related to getting a surface. Fullscreen is mentioned
there,
> but it's not clear that the reason is related to this.
> 
> qinmin@?

[qinmin, 2015-03-20 20:31:49]

https://codereview.chromium.org/1021723003/diff/1/content/browser/media/andro...
File content/browser/media/android/browser_media_player_manager.h (left):

https://codereview.chromium.org/1021723003/diff/1/content/browser/media/andro...
content/browser/media/android/browser_media_player_manager.h:100: bool
ShouldUseVideoOverlayForEmbeddedEncryptedVideo() override;
On 2015/03/20 19:47:46, qinmin wrote:
> This surface is for hole punching and probably we don't want to remove it. TV
> uses this to show L1 video for non-fullscreen mode
> 
> On 2015/03/20 18:45:25, ddorwin wrote:
> > On 2015/03/20 18:07:44, xhwang wrote:
> > > How about the renderer side? e.g.
> > > 
> > >
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/m...
> > > 
> > >
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/m...
> > 
> > This appears to be related to getting a surface. Fullscreen is mentioned
> there,
> > but it's not clear that the reason is related to this.
> > 
> > qinmin@?
> 

To be clear, browser side call is only used to request fullscreen, so we can
remove it here.
Renderer side call is needed by WebMediaPlayerAndroid to attach the hole
punching surface to the player, so we should keep the call.

[qinmin, 2015-03-20 20:32:56]

lgtm

[gunsch, 2015-03-20 21:04:04]

lgtm from Cast-ATV perspective

[xhwang, 2015-03-20 23:44:50]

lgtm. We have a lot to fix, but we can do that later.

[ddorwin, 2015-03-20 23:45:07]

The CQ bit was checked by ddorwin@chromium.org

[commit-bot: I haz the power, 2015-03-20 23:45:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1021723003/20001

[commit-bot: I haz the power, 2015-03-21 00:32:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-21 00:33:14]

Patchset 2 (id:??) landed as
https://crrev.com/a1a3db25697c8cbc046a77a0c0a4e706f7f31be6
Cr-Commit-Position: refs/heads/master@{#321668}