content/browser/media/android/browser_media_player_manager.cc - Issue 1156273006: Remove unused code calling WebMediaPlayerClient::requestFullscreen()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/android/browser_media_player_manager.cc

Issue 1156273006: Remove unused code calling WebMediaPlayerClient::requestFullscreen() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/media/android/browser_media_player_manager.h ('k') | content/common/media/media_player_messages_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/media/android/browser_media_player_manager.cc

diff --git a/content/browser/media/android/browser_media_player_manager.cc b/content/browser/media/android/browser_media_player_manager.cc

index c77ead00d628256ff9c02032484d8daab23525c4..32e2c0455d4181a0829f1b32fc0d003788607945 100644

--- a/content/browser/media/android/browser_media_player_manager.cc

+++ b/content/browser/media/android/browser_media_player_manager.cc

@@ -335,19 +335,6 @@ MediaPlayerAndroid* BrowserMediaPlayerManager::GetPlayer(int player_id) {

return NULL;

}

-void BrowserMediaPlayerManager::RequestFullScreen(int player_id) {

- if (fullscreen_player_id_ == player_id)

- return;

- if (fullscreen_player_id_ != kInvalidMediaPlayerId) {

- // TODO(qinmin): Determine the correct error code we should report to WMPA.

- OnError(player_id, MediaPlayerAndroid::MEDIA_ERROR_DECODE);

- return;

- }

- Send(new MediaPlayerMsg_RequestFullscreen(RoutingID(), player_id));

bool BrowserMediaPlayerManager::RequestPlay(int player_id) {

MediaPlayerAndroid* player = GetPlayer(player_id);

DCHECK(player);