Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1157253010: Remove WebMediaPlayerClient::requestFullscreen() (Closed)

Created:
5 years, 6 months ago by philipj_slow
Modified:
5 years, 6 months ago
Reviewers:
Mike West
CC:
arv+blink, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, Rik, Inactive, danakj, dglazkov+blink, dshwang, krit, eae+blinkwatch, eric.carlson_apple.com, feature-media-reviews_chromium.org, f(malita), fs, gasubic, jbroman, Justin Novosad, mlamouri+watch-blink_chromium.org, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, sof, nessy, vcarbune.chromium, vivekg_samsung, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove WebMediaPlayerClient::requestFullscreen() This was used for a while and then removed again: https://codereview.chromium.org/41123002 https://codereview.chromium.org/1021723003 BUG=496627 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197089

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -57 lines) Patch
D LayoutTests/media/media-player-request-fullscreen.html View 1 chunk +0 lines, -22 lines 0 comments Download
D LayoutTests/media/media-player-request-fullscreen-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/html/HTMLMediaElement.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 1 chunk +0 lines, -11 lines 0 comments Download
M Source/core/testing/Internals.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/graphics/media/MediaPlayer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebMediaPlayerClientImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebMediaPlayerClientImpl.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download
M public/platform/WebMediaPlayerClient.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
philipj_slow
PTAL, cleanup after https://codereview.chromium.org/1156273006/
5 years, 6 months ago (2015-06-12 07:39:17 UTC) #2
philipj_slow
Sorry, please hold off review, I forgot I need to rebase this first. PTAL when ...
5 years, 6 months ago (2015-06-12 08:07:15 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157253010/20001
5 years, 6 months ago (2015-06-12 09:48:59 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-12 12:08:08 UTC) #7
philipj_slow
All green, PTAL :)
5 years, 6 months ago (2015-06-12 12:44:54 UTC) #8
Mike West
LGTM!
5 years, 6 months ago (2015-06-13 08:06:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157253010/20001
5 years, 6 months ago (2015-06-13 14:39:54 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-13 16:49:25 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197089

Powered by Google App Engine
This is Rietveld 408576698