Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 1154283003: Change most uses of Pickle to base::Pickle (Closed)

Created:
5 years, 6 months ago by brettw
Modified:
5 years, 6 months ago
Reviewers:
jschuh, sky
CC:
chromium-reviews, asanka, serviceworker-reviews, yusukes+watch_chromium.org, tzik, posciak+watch_chromium.org, gavinp+disk_chromium.org, vabr+watchlist_chromium.org, nasko+codewatch_chromium.org, browser-components-watch_chromium.org, dcheng, sievers+watch_chromium.org, scheib+watch_chromium.org, noyau+watch_chromium.org, piman+watch_chromium.org, mlamouri+watch-content_chromium.org, markusheintz_, jdduke+watch_chromium.org, kinuko+watch, qsr+mojo_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, Matt Giuca, Aaron Boodman, benjhayden+dwatch_chromium.org, grt+watch_chromium.org, lcwu+watch_chromium.org, viettrungluu+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, ben+mojo_chromium.org, abarth-chromium, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, jkarlin+watch_chromium.org, darin (slow to review), chromium-apps-reviews_chromium.org, android-webview-reviews_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org, cc-bugs_chromium.org, chromoting-reviews_chromium.org, creis+watch_chromium.org, dgrogan, tapted, mlamouri+watch-notifications_chromium.org, penghuang+watch_chromium.org, nhiroki, rickyz+watch_chromium.org, feature-media-reviews_chromium.org, johnme+watch_chromium.org, klundberg+watch_chromium.org, yzshen+watch_chromium.org, kalyank, gunsch+watch_chromium.org, gcasto+watchlist_chromium.org, jsbell+idb_chromium.org, peter+watch_chromium.org, rouslan+autofillwatch_chromium.org, mkwst+watchlist-passwords_chromium.org, michaeln, tfarina, horo+watch_chromium.org, shuchen+watch_chromium.org, mcasas+watch_chromium.org, kinuko+fileapi, mvanouwerkerk+watch_chromium.org, kinuko+serviceworker, cmumford, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, danakj+watch_chromium.org, James Su, wjia+watch_chromium.org, scheduler-bugs_chromium.org, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change most uses of Pickle to base::Pickle There should be no behavior change. TBR=jschuh (IPC messages) Committed: https://crrev.com/bd4d71128239a38fa844c42e4110458109a8b135 Cr-Commit-Position: refs/heads/master@{#332552}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+986 lines, -841 lines) Patch
M android_webview/native/aw_contents.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M android_webview/native/state_serializer.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M android_webview/native/state_serializer_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/android/tab_state.cc View 9 chunks +18 lines, -16 lines 0 comments Download
M chrome/browser/extensions/api/automation_internal/automation_internal_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/page_capture/page_capture_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_action.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/webrtc_log_uploader.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/native_backend_kwallet_x.cc View 9 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc View 14 chunks +27 lines, -21 lines 0 comments Download
M chrome/browser/renderer_host/pepper/pepper_flash_clipboard_message_filter.cc View 5 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/safe_browsing/malware_details_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/fast_show_pickler.cc View 6 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/ui/app_list/test/fast_show_pickler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/browser_action_drag_data.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/content_settings_pattern_serializer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/render_messages.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/common/safe_browsing/ipc_protobuf_message_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chromecast/common/media/cma_param_traits.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M cloud_print/service/win/setup_listener.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/common/form_data.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M components/autofill/core/common/form_data_unittest.cc View 7 chunks +13 lines, -11 lines 0 comments Download
M components/autofill/core/common/form_field_data.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M components/autofill/core/common/form_field_data_unittest.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M components/bookmarks/browser/bookmark_node_data.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M components/bookmarks/browser/bookmark_node_data_views.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/nacl/browser/nacl_browser.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/nacl/browser/nacl_validation_cache.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M components/nacl/browser/nacl_validation_cache_unittest.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M components/nacl/loader/nacl_helper_linux.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M components/nacl/loader/nacl_ipc_adapter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/nacl/zygote/nacl_fork_delegate_linux.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M components/network_hints/common/network_hints_messages.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/login_database.cc View 4 chunks +11 lines, -10 lines 0 comments Download
M components/password_manager/core/browser/login_database_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/sessions/base_session_service_commands.cc View 6 chunks +15 lines, -13 lines 0 comments Download
M components/sessions/serialized_navigation_entry.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M components/sessions/serialized_navigation_entry_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sessions/session_command.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/sessions/session_service_commands.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M components/visitedlink/test/visitedlink_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/java/gin_java_bridge_dispatcher_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/appcache/appcache_response.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M content/browser/appcache/appcache_response_unittest.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M content/browser/appcache/appcache_service_unittest.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/appcache/appcache_url_request_job_unittest.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/base_file.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_unittest.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M content/browser/loader/resource_scheduler_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/clipboard_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/input_router_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/sandbox_ipc_linux.cc View 15 chunks +17 lines, -17 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M content/browser/web_contents/web_drag_source_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/zygote_host/zygote_host_impl_linux.cc View 8 chunks +10 lines, -10 lines 0 comments Download
M content/child/bluetooth/bluetooth_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/geofencing/geofencing_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/indexed_db/indexed_db_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/navigator_connect/navigator_connect_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/notifications/notification_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/npapi/npruntime_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/plugin_param_traits.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/push_messaging/push_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/quota_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/resource_dispatcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/service_worker/service_worker_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/threaded_data_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/android/gin_java_bridge_value.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/common/cc_messages.cc View 11 chunks +21 lines, -16 lines 0 comments Download
M content/common/cc_messages_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M content/common/child_process_sandbox_support_impl_linux.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M content/common/child_process_sandbox_support_impl_shm_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/common_param_traits_unittest.cc View 13 chunks +13 lines, -13 lines 0 comments Download
M content/common/content_param_traits.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/cursors/webcursor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/font_config_ipc_linux.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M content/common/gamepad_param_traits.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M content/common/indexed_db/indexed_db_param_traits.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/common/input/input_param_traits.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M content/common/input/input_param_traits_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/common/mac/attributed_string_coder.mm View 2 chunks +6 lines, -2 lines 0 comments Download
M content/common/media/media_param_traits.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/page_state_serialization.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/common/page_state_serialization_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/resource_messages.cc View 5 chunks +14 lines, -9 lines 0 comments Download
M content/common/ssl_status_serialization.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/common/common_param_traits.cc View 5 chunks +10 lines, -6 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/cache_storage/cache_storage_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/scheduler/resource_dispatch_throttler_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/service_worker/embedded_worker_context_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/zygote/zygote_linux.cc View 9 chunks +11 lines, -14 lines 0 comments Download
M content/zygote/zygote_main_linux.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M crypto/secure_hash_default.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M crypto/secure_hash_openssl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M crypto/secure_hash_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/sandboxed_unpacker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/script_executor.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/user_script_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/sockets/sockets_manifest_permission_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/common/extension_messages.cc View 9 chunks +25 lines, -16 lines 0 comments Download
M extensions/common/permissions/api_permission.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/permissions/api_permission_set_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/permissions/manifest_permission.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/common/permissions/settings_override_permission.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/permissions/socket_permission_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/common/user_script.h View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/common/user_script_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/renderer/user_script_set.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M gpu/ipc/gpu_command_buffer_traits.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M ipc/ipc_channel_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_channel_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_channel_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_fuzzing_tests.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M ipc/ipc_logging.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_message.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M ipc/ipc_message_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ipc/ipc_message_utils.h View 45 chunks +111 lines, -48 lines 0 comments Download
M ipc/ipc_message_utils.cc View 26 chunks +55 lines, -37 lines 0 comments Download
M ipc/ipc_message_utils_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ipc/ipc_perftest_support.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/ipc_send_fds_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_sync_message.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ipc/ipc_test_channel_listener.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/mojo/ipc_channel_mojo_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M ipc/mojo/ipc_mojo_bootstrap.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/mojo/ipc_mojo_message_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/mojo/ipc_mojo_param_traits.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/test_helpers.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/base/io_buffer.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M net/cert/signed_certificate_timestamp.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/cert/signed_certificate_timestamp_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/cert/x509_certificate.h View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/x509_certificate.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M net/cert/x509_certificate_ios.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/cert/x509_certificate_mac.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/cert/x509_certificate_nss.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/cert/x509_certificate_openssl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/cert/x509_certificate_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/cert/x509_certificate_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/cert/x509_util_nss_certs.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/simple/simple_index.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/disk_cache/simple/simple_index_file.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/disk_cache/simple/simple_index_file.cc View 9 chunks +12 lines, -11 lines 0 comments Download
M net/disk_cache/simple/simple_index_file_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/disk_cache/simple/simple_index_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_cache_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_response_headers.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/http/http_response_headers_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_response_info.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/http/http_response_info_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_vary_data.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/mock_http_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/quic_server_info.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/url_request/view_cache_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/nacl_irt/ppapi_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppapi_param_traits.cc View 19 chunks +33 lines, -29 lines 0 comments Download
M ppapi/proxy/raw_var_data.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M ppapi/proxy/raw_var_data_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/resource_message_params.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M ppapi/proxy/serialized_flash_menu.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M ppapi/proxy/serialized_handle.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/serialized_var.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/url_loader_resource.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/chromoting_param_traits.cc View 5 chunks +7 lines, -8 lines 0 comments Download
M sandbox/linux/syscall_broker/broker_client.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M sandbox/linux/syscall_broker/broker_host.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M skia/ext/skia_utils_base.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M storage/browser/fileapi/file_system_usage_cache.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M storage/browser/fileapi/sandbox_directory_database.cc View 8 chunks +10 lines, -9 lines 0 comments Download
M storage/browser/fileapi/sandbox_prioritized_origin_database.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/message_pipe_perftest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/android/forwarder2/host_forwarder_main.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M ui/base/clipboard/custom_data_helper.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M ui/base/clipboard/custom_data_helper_unittest.cc View 11 chunks +12 lines, -12 lines 0 comments Download
M ui/base/clipboard/scoped_clipboard_writer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/base/dragdrop/os_exchange_data.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_aura.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_aurax11.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_mac.mm View 2 chunks +4 lines, -3 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/gfx/ipc/gfx_param_traits.cc View 10 chunks +13 lines, -12 lines 0 comments Download
M ui/views/controls/textfield/textfield_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 33 (15 generated)
brettw
5 years, 6 months ago (2015-06-02 18:05:08 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154283003/1
5 years, 6 months ago (2015-06-02 18:08:03 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/58606)
5 years, 6 months ago (2015-06-02 18:44:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154283003/20001
5 years, 6 months ago (2015-06-02 19:15:05 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 6 months ago (2015-06-02 19:15:11 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154283003/20001
5 years, 6 months ago (2015-06-02 19:18:49 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/89544) win_chromium_x64_rel_ng on ...
5 years, 6 months ago (2015-06-02 19:45:30 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154283003/40001
5 years, 6 months ago (2015-06-02 20:10:07 UTC) #16
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 6 months ago (2015-06-02 20:10:20 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154283003/40001
5 years, 6 months ago (2015-06-02 21:24:25 UTC) #20
sky
Rubber stamp LGTM
5 years, 6 months ago (2015-06-02 23:13:04 UTC) #21
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-03 03:11:47 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154283003/40001
5 years, 6 months ago (2015-06-03 03:21:33 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/67845)
5 years, 6 months ago (2015-06-03 03:38:01 UTC) #27
brettw
TBR jschuh for IPC
5 years, 6 months ago (2015-06-03 04:19:37 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154283003/40001
5 years, 6 months ago (2015-06-03 04:20:38 UTC) #31
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-03 04:29:53 UTC) #32
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 04:30:58 UTC) #33
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bd4d71128239a38fa844c42e4110458109a8b135
Cr-Commit-Position: refs/heads/master@{#332552}

Powered by Google App Engine
This is Rietveld 408576698