Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: components/autofill/core/common/form_data_unittest.cc

Issue 1154283003: Change most uses of Pickle to base::Pickle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/autofill/core/common/form_data.h" 5 #include "components/autofill/core/common/form_data.h"
6 6
7 #include "base/pickle.h" 7 #include "base/pickle.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "components/autofill/core/common/form_field_data.h" 9 #include "components/autofill/core/common/form_field_data.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
11 11
12 namespace autofill { 12 namespace autofill {
13 13
14 namespace { 14 namespace {
15 15
16 // This function serializes the form data into the pickle in version one format. 16 // This function serializes the form data into the pickle in version one format.
17 // It should always be possible to deserialize it using DeserializeFormData(), 17 // It should always be possible to deserialize it using DeserializeFormData(),
18 // even when version changes. See kPickleVersion in form_data.cc. 18 // even when version changes. See kPickleVersion in form_data.cc.
19 void SerializeInVersion1Format(const FormData& form_data, Pickle* pickle) { 19 void SerializeInVersion1Format(const FormData& form_data,
20 base::Pickle* pickle) {
20 DCHECK_EQ(true, form_data.is_form_tag); 21 DCHECK_EQ(true, form_data.is_form_tag);
21 pickle->WriteInt(1); 22 pickle->WriteInt(1);
22 pickle->WriteString16(form_data.name); 23 pickle->WriteString16(form_data.name);
23 base::string16 method(base::ASCIIToUTF16("POST")); 24 base::string16 method(base::ASCIIToUTF16("POST"));
24 pickle->WriteString16(method); 25 pickle->WriteString16(method);
25 pickle->WriteString(form_data.origin.spec()); 26 pickle->WriteString(form_data.origin.spec());
26 pickle->WriteString(form_data.action.spec()); 27 pickle->WriteString(form_data.action.spec());
27 pickle->WriteBool(form_data.user_submitted); 28 pickle->WriteBool(form_data.user_submitted);
28 pickle->WriteInt(static_cast<int>(form_data.fields.size())); 29 pickle->WriteInt(static_cast<int>(form_data.fields.size()));
29 for (size_t i = 0; i < form_data.fields.size(); ++i) { 30 for (size_t i = 0; i < form_data.fields.size(); ++i) {
30 SerializeFormFieldData(form_data.fields[i], pickle); 31 SerializeFormFieldData(form_data.fields[i], pickle);
31 } 32 }
32 } 33 }
33 34
34 void SerializeInVersion2Format(const FormData& form_data, Pickle* pickle) { 35 void SerializeInVersion2Format(const FormData& form_data,
36 base::Pickle* pickle) {
35 DCHECK_EQ(true, form_data.is_form_tag); 37 DCHECK_EQ(true, form_data.is_form_tag);
36 pickle->WriteInt(2); 38 pickle->WriteInt(2);
37 pickle->WriteString16(form_data.name); 39 pickle->WriteString16(form_data.name);
38 pickle->WriteString(form_data.origin.spec()); 40 pickle->WriteString(form_data.origin.spec());
39 pickle->WriteString(form_data.action.spec()); 41 pickle->WriteString(form_data.action.spec());
40 pickle->WriteBool(form_data.user_submitted); 42 pickle->WriteBool(form_data.user_submitted);
41 pickle->WriteInt(static_cast<int>(form_data.fields.size())); 43 pickle->WriteInt(static_cast<int>(form_data.fields.size()));
42 for (size_t i = 0; i < form_data.fields.size(); ++i) { 44 for (size_t i = 0; i < form_data.fields.size(); ++i) {
43 SerializeFormFieldData(form_data.fields[i], pickle); 45 SerializeFormFieldData(form_data.fields[i], pickle);
44 } 46 }
45 } 47 }
46 48
47 // This function serializes the form data into the pickle in incorrect format 49 // This function serializes the form data into the pickle in incorrect format
48 // (no version number). 50 // (no version number).
49 void SerializeIncorrectFormat(const FormData& form_data, Pickle* pickle) { 51 void SerializeIncorrectFormat(const FormData& form_data, base::Pickle* pickle) {
50 pickle->WriteString16(form_data.name); 52 pickle->WriteString16(form_data.name);
51 pickle->WriteString(form_data.origin.spec()); 53 pickle->WriteString(form_data.origin.spec());
52 pickle->WriteString(form_data.action.spec()); 54 pickle->WriteString(form_data.action.spec());
53 pickle->WriteBool(form_data.user_submitted); 55 pickle->WriteBool(form_data.user_submitted);
54 pickle->WriteInt(static_cast<int>(form_data.fields.size())); 56 pickle->WriteInt(static_cast<int>(form_data.fields.size()));
55 for (size_t i = 0; i < form_data.fields.size(); ++i) { 57 for (size_t i = 0; i < form_data.fields.size(); ++i) {
56 SerializeFormFieldData(form_data.fields[i], pickle); 58 SerializeFormFieldData(form_data.fields[i], pickle);
57 } 59 }
58 } 60 }
59 61
(...skipping 30 matching lines...) Expand all
90 data->fields.push_back(field_data); 92 data->fields.push_back(field_data);
91 } 93 }
92 94
93 } // namespace 95 } // namespace
94 96
95 TEST(FormDataTest, SerializeAndDeserialize) { 97 TEST(FormDataTest, SerializeAndDeserialize) {
96 FormData data; 98 FormData data;
97 FillInDummyFormData(&data); 99 FillInDummyFormData(&data);
98 data.is_form_tag = false; 100 data.is_form_tag = false;
99 101
100 Pickle pickle; 102 base::Pickle pickle;
101 SerializeFormData(data, &pickle); 103 SerializeFormData(data, &pickle);
102 104
103 PickleIterator iter(pickle); 105 base::PickleIterator iter(pickle);
104 FormData actual; 106 FormData actual;
105 EXPECT_TRUE(DeserializeFormData(&iter, &actual)); 107 EXPECT_TRUE(DeserializeFormData(&iter, &actual));
106 108
107 EXPECT_TRUE(actual.SameFormAs(data)); 109 EXPECT_TRUE(actual.SameFormAs(data));
108 } 110 }
109 111
110 TEST(FormDataTest, Serialize_v1_Deserialize_vCurrent) { 112 TEST(FormDataTest, Serialize_v1_Deserialize_vCurrent) {
111 FormData data; 113 FormData data;
112 FillInDummyFormData(&data); 114 FillInDummyFormData(&data);
113 115
114 Pickle pickle; 116 base::Pickle pickle;
115 SerializeInVersion1Format(data, &pickle); 117 SerializeInVersion1Format(data, &pickle);
116 118
117 PickleIterator iter(pickle); 119 base::PickleIterator iter(pickle);
118 FormData actual; 120 FormData actual;
119 EXPECT_TRUE(DeserializeFormData(&iter, &actual)); 121 EXPECT_TRUE(DeserializeFormData(&iter, &actual));
120 122
121 EXPECT_TRUE(actual.SameFormAs(data)); 123 EXPECT_TRUE(actual.SameFormAs(data));
122 } 124 }
123 125
124 TEST(FormDataTest, Serialize_v2_Deserialize_vCurrent) { 126 TEST(FormDataTest, Serialize_v2_Deserialize_vCurrent) {
125 FormData data; 127 FormData data;
126 FillInDummyFormData(&data); 128 FillInDummyFormData(&data);
127 129
128 Pickle pickle; 130 base::Pickle pickle;
129 SerializeInVersion2Format(data, &pickle); 131 SerializeInVersion2Format(data, &pickle);
130 132
131 PickleIterator iter(pickle); 133 base::PickleIterator iter(pickle);
132 FormData actual; 134 FormData actual;
133 EXPECT_TRUE(DeserializeFormData(&iter, &actual)); 135 EXPECT_TRUE(DeserializeFormData(&iter, &actual));
134 136
135 EXPECT_TRUE(actual.SameFormAs(data)); 137 EXPECT_TRUE(actual.SameFormAs(data));
136 } 138 }
137 139
138 TEST(FormDataTest, SerializeIncorrectFormatAndDeserialize) { 140 TEST(FormDataTest, SerializeIncorrectFormatAndDeserialize) {
139 FormData data; 141 FormData data;
140 FillInDummyFormData(&data); 142 FillInDummyFormData(&data);
141 143
142 Pickle pickle; 144 base::Pickle pickle;
143 SerializeIncorrectFormat(data, &pickle); 145 SerializeIncorrectFormat(data, &pickle);
144 146
145 PickleIterator iter(pickle); 147 base::PickleIterator iter(pickle);
146 FormData actual; 148 FormData actual;
147 EXPECT_FALSE(DeserializeFormData(&iter, &actual)); 149 EXPECT_FALSE(DeserializeFormData(&iter, &actual));
148 150
149 FormData empty; 151 FormData empty;
150 EXPECT_TRUE(actual.SameFormAs(empty)); 152 EXPECT_TRUE(actual.SameFormAs(empty));
151 } 153 }
152 154
153 TEST(FormDataTest, SerializeAndDeserializeInStrings) { 155 TEST(FormDataTest, SerializeAndDeserializeInStrings) {
154 FormData data; 156 FormData data;
155 FillInDummyFormData(&data); 157 FillInDummyFormData(&data);
156 data.is_form_tag = false; 158 data.is_form_tag = false;
157 159
158 std::string serialized_data; 160 std::string serialized_data;
159 SerializeFormDataToBase64String(data, &serialized_data); 161 SerializeFormDataToBase64String(data, &serialized_data);
160 162
161 FormData actual; 163 FormData actual;
162 EXPECT_TRUE(DeserializeFormDataFromBase64String(serialized_data, &actual)); 164 EXPECT_TRUE(DeserializeFormDataFromBase64String(serialized_data, &actual));
163 165
164 EXPECT_TRUE(actual.SameFormAs(data)); 166 EXPECT_TRUE(actual.SameFormAs(data));
165 } 167 }
166 168
167 } // namespace autofill 169 } // namespace autofill
OLDNEW
« no previous file with comments | « components/autofill/core/common/form_data.cc ('k') | components/autofill/core/common/form_field_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698