Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: android_webview/native/state_serializer_unittest.cc

Issue 1154283003: Change most uses of Pickle to base::Pickle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « android_webview/native/state_serializer.cc ('k') | chrome/browser/android/tab_state.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/native/state_serializer.h" 5 #include "android_webview/native/state_serializer.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/pickle.h" 10 #include "base/pickle.h"
11 #include "base/strings/utf_string_conversions.h" 11 #include "base/strings/utf_string_conversions.h"
12 #include "base/time/time.h" 12 #include "base/time/time.h"
13 #include "content/public/browser/content_browser_client.h" 13 #include "content/public/browser/content_browser_client.h"
14 #include "content/public/browser/navigation_entry.h" 14 #include "content/public/browser/navigation_entry.h"
15 #include "content/public/common/content_client.h" 15 #include "content/public/common/content_client.h"
16 #include "content/public/common/page_state.h" 16 #include "content/public/common/page_state.h"
17 #include "testing/gtest/include/gtest/gtest.h" 17 #include "testing/gtest/include/gtest/gtest.h"
18 #include "url/gurl.h" 18 #include "url/gurl.h"
19 19
20 using std::string; 20 using std::string;
21 21
22 namespace android_webview { 22 namespace android_webview {
23 23
24 TEST(AndroidWebViewStateSerializerTest, TestHeaderSerialization) { 24 TEST(AndroidWebViewStateSerializerTest, TestHeaderSerialization) {
25 Pickle pickle; 25 base::Pickle pickle;
26 bool result = internal::WriteHeaderToPickle(&pickle); 26 bool result = internal::WriteHeaderToPickle(&pickle);
27 EXPECT_TRUE(result); 27 EXPECT_TRUE(result);
28 28
29 PickleIterator iterator(pickle); 29 base::PickleIterator iterator(pickle);
30 result = internal::RestoreHeaderFromPickle(&iterator); 30 result = internal::RestoreHeaderFromPickle(&iterator);
31 EXPECT_TRUE(result); 31 EXPECT_TRUE(result);
32 } 32 }
33 33
34 TEST(AndroidWebViewStateSerializerTest, TestNavigationEntrySerialization) { 34 TEST(AndroidWebViewStateSerializerTest, TestNavigationEntrySerialization) {
35 // This is required for NavigationEntry::Create. 35 // This is required for NavigationEntry::Create.
36 content::ContentClient content_client; 36 content::ContentClient content_client;
37 content::SetContentClient(&content_client); 37 content::SetContentClient(&content_client);
38 content::ContentBrowserClient browser_client; 38 content::ContentBrowserClient browser_client;
39 content::SetBrowserClientForTesting(&browser_client); 39 content::SetBrowserClientForTesting(&browser_client);
(...skipping 21 matching lines...) Expand all
61 entry->SetReferrer(referrer); 61 entry->SetReferrer(referrer);
62 entry->SetTitle(title); 62 entry->SetTitle(title);
63 entry->SetPageState(page_state); 63 entry->SetPageState(page_state);
64 entry->SetHasPostData(has_post_data); 64 entry->SetHasPostData(has_post_data);
65 entry->SetOriginalRequestURL(original_request_url); 65 entry->SetOriginalRequestURL(original_request_url);
66 entry->SetBaseURLForDataURL(base_url_for_data_url); 66 entry->SetBaseURLForDataURL(base_url_for_data_url);
67 entry->SetIsOverridingUserAgent(is_overriding_user_agent); 67 entry->SetIsOverridingUserAgent(is_overriding_user_agent);
68 entry->SetTimestamp(timestamp); 68 entry->SetTimestamp(timestamp);
69 entry->SetHttpStatusCode(http_status_code); 69 entry->SetHttpStatusCode(http_status_code);
70 70
71 Pickle pickle; 71 base::Pickle pickle;
72 bool result = internal::WriteNavigationEntryToPickle(*entry, &pickle); 72 bool result = internal::WriteNavigationEntryToPickle(*entry, &pickle);
73 EXPECT_TRUE(result); 73 EXPECT_TRUE(result);
74 74
75 scoped_ptr<content::NavigationEntry> copy(content::NavigationEntry::Create()); 75 scoped_ptr<content::NavigationEntry> copy(content::NavigationEntry::Create());
76 PickleIterator iterator(pickle); 76 base::PickleIterator iterator(pickle);
77 result = internal::RestoreNavigationEntryFromPickle(&iterator, copy.get()); 77 result = internal::RestoreNavigationEntryFromPickle(&iterator, copy.get());
78 EXPECT_TRUE(result); 78 EXPECT_TRUE(result);
79 79
80 EXPECT_EQ(url, copy->GetURL()); 80 EXPECT_EQ(url, copy->GetURL());
81 EXPECT_EQ(virtual_url, copy->GetVirtualURL()); 81 EXPECT_EQ(virtual_url, copy->GetVirtualURL());
82 EXPECT_EQ(referrer.url, copy->GetReferrer().url); 82 EXPECT_EQ(referrer.url, copy->GetReferrer().url);
83 EXPECT_EQ(referrer.policy, copy->GetReferrer().policy); 83 EXPECT_EQ(referrer.policy, copy->GetReferrer().policy);
84 EXPECT_EQ(title, copy->GetTitle()); 84 EXPECT_EQ(title, copy->GetTitle());
85 EXPECT_EQ(page_state, copy->GetPageState()); 85 EXPECT_EQ(page_state, copy->GetPageState());
86 EXPECT_EQ(has_post_data, copy->GetHasPostData()); 86 EXPECT_EQ(has_post_data, copy->GetHasPostData());
87 EXPECT_EQ(original_request_url, copy->GetOriginalRequestURL()); 87 EXPECT_EQ(original_request_url, copy->GetOriginalRequestURL());
88 EXPECT_EQ(base_url_for_data_url, copy->GetBaseURLForDataURL()); 88 EXPECT_EQ(base_url_for_data_url, copy->GetBaseURLForDataURL());
89 EXPECT_EQ(is_overriding_user_agent, copy->GetIsOverridingUserAgent()); 89 EXPECT_EQ(is_overriding_user_agent, copy->GetIsOverridingUserAgent());
90 EXPECT_EQ(timestamp, copy->GetTimestamp()); 90 EXPECT_EQ(timestamp, copy->GetTimestamp());
91 EXPECT_EQ(http_status_code, copy->GetHttpStatusCode()); 91 EXPECT_EQ(http_status_code, copy->GetHttpStatusCode());
92 } 92 }
93 93
94 } // namespace android_webview 94 } // namespace android_webview
OLDNEW
« no previous file with comments | « android_webview/native/state_serializer.cc ('k') | chrome/browser/android/tab_state.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698