chrome/common/safe_browsing/ipc_protobuf_message_unittest.cc - Issue 1154283003: Change most uses of Pickle to base::Pickle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/safe_browsing/ipc_protobuf_message_unittest.cc

Issue 1154283003: Change most uses of Pickle to base::Pickle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/safe_browsing/ipc_protobuf_message_unittest.cc

diff --git a/chrome/common/safe_browsing/ipc_protobuf_message_unittest.cc b/chrome/common/safe_browsing/ipc_protobuf_message_unittest.cc

index 0e9f4c9be9c6c5af1ed2728e268b8d166281ac77..d2fda1f48f84c42c380c506f929167718183566b 100644

--- a/chrome/common/safe_browsing/ipc_protobuf_message_unittest.cc

+++ b/chrome/common/safe_browsing/ipc_protobuf_message_unittest.cc

@@ -45,7 +45,7 @@ TEST_P(IPCProtobufMessageTest, FundamentalField) {

IPC::WriteParam(&msg, input);

TestMessage output;

- PickleIterator iter(msg);

+ base::PickleIterator iter(msg);

ASSERT_TRUE(IPC::ReadParam(&msg, &iter, &output));

if (field_is_present_) {

@@ -67,7 +67,7 @@ TEST_P(IPCProtobufMessageTest, StringField) {

IPC::WriteParam(&msg, input);

TestMessage output;

- PickleIterator iter(msg);

+ base::PickleIterator iter(msg);

ASSERT_TRUE(IPC::ReadParam(&msg, &iter, &output));

if (field_is_present_) {

@@ -89,7 +89,7 @@ TEST_P(IPCProtobufMessageTest, BytesField) {

IPC::WriteParam(&msg, input);

TestMessage output;

- PickleIterator iter(msg);

+ base::PickleIterator iter(msg);

ASSERT_TRUE(IPC::ReadParam(&msg, &iter, &output));

if (field_is_present_) {

@@ -111,7 +111,7 @@ TEST_P(IPCProtobufMessageTest, OptionalSubmessage) {

IPC::WriteParam(&msg, input);

TestMessage output;

- PickleIterator iter(msg);

+ base::PickleIterator iter(msg);

ASSERT_TRUE(IPC::ReadParam(&msg, &iter, &output));

if (field_is_present_) {

@@ -137,7 +137,7 @@ TEST_P(IPCProtobufMessageTest, RepeatedSubmessage) {

IPC::WriteParam(&msg, input);

TestMessage output;

- PickleIterator iter(msg);

+ base::PickleIterator iter(msg);

ASSERT_TRUE(IPC::ReadParam(&msg, &iter, &output));

if (field_is_present_) {

« no previous file with comments | « chrome/common/render_messages.cc ('k') | chromecast/common/media/cma_param_traits.cc » ('j') | no next file with comments »