Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: content/browser/renderer_host/sandbox_ipc_linux.cc

Issue 1154283003: Change most uses of Pickle to base::Pickle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/sandbox_ipc_linux.cc
diff --git a/content/browser/renderer_host/sandbox_ipc_linux.cc b/content/browser/renderer_host/sandbox_ipc_linux.cc
index bc24bca724955927cb79c4cc8dcba665281e9108..f497d74f8ca178b3289a8256db6733b72b208716 100644
--- a/content/browser/renderer_host/sandbox_ipc_linux.cc
+++ b/content/browser/renderer_host/sandbox_ipc_linux.cc
@@ -140,8 +140,8 @@ void SandboxIPCHandler::HandleRequestFromRenderer(int fd) {
if (fds.empty())
return;
- Pickle pickle(buf, len);
- PickleIterator iter(pickle);
+ base::Pickle pickle(buf, len);
+ base::PickleIterator iter(pickle);
int kind;
if (!iter.ReadInt(&kind))
@@ -176,7 +176,7 @@ int SandboxIPCHandler::FindOrAddPath(const SkString& path) {
void SandboxIPCHandler::HandleFontMatchRequest(
int fd,
- PickleIterator iter,
+ base::PickleIterator iter,
const std::vector<base::ScopedFD*>& fds) {
uint32_t requested_style;
std::string family;
@@ -195,7 +195,7 @@ void SandboxIPCHandler::HandleFontMatchRequest(
&result_family,
&result_style);
- Pickle reply;
+ base::Pickle reply;
if (!r) {
reply.WriteBool(false);
} else {
@@ -214,7 +214,7 @@ void SandboxIPCHandler::HandleFontMatchRequest(
void SandboxIPCHandler::HandleFontOpenRequest(
int fd,
- PickleIterator iter,
+ base::PickleIterator iter,
const std::vector<base::ScopedFD*>& fds) {
uint32_t index;
if (!iter.ReadUInt32(&index))
@@ -223,7 +223,7 @@ void SandboxIPCHandler::HandleFontOpenRequest(
return;
const int result_fd = open(paths_[index]->c_str(), O_RDONLY);
- Pickle reply;
+ base::Pickle reply;
if (result_fd == -1) {
reply.WriteBool(false);
} else {
@@ -242,7 +242,7 @@ void SandboxIPCHandler::HandleFontOpenRequest(
void SandboxIPCHandler::HandleGetFallbackFontForChar(
int fd,
- PickleIterator iter,
+ base::PickleIterator iter,
const std::vector<base::ScopedFD*>& fds) {
// The other side of this call is
// content/common/child_process_sandbox_support_impl_linux.cc
@@ -262,7 +262,7 @@ void SandboxIPCHandler::HandleGetFallbackFontForChar(
int pathIndex = FindOrAddPath(SkString(fallbackFont.filename.data()));
fallbackFont.fontconfigInterfaceId = pathIndex;
- Pickle reply;
+ base::Pickle reply;
if (fallbackFont.name.data()) {
reply.WriteString(fallbackFont.name.data());
} else {
@@ -282,7 +282,7 @@ void SandboxIPCHandler::HandleGetFallbackFontForChar(
void SandboxIPCHandler::HandleGetStyleForStrike(
int fd,
- PickleIterator iter,
+ base::PickleIterator iter,
const std::vector<base::ScopedFD*>& fds) {
std::string family;
bool bold, italic;
@@ -306,7 +306,7 @@ void SandboxIPCHandler::HandleGetStyleForStrike(
// These are passed as ints since they're interpreted as tri-state chars in
// Blink.
- Pickle reply;
+ base::Pickle reply;
reply.WriteInt(params.use_bitmaps);
reply.WriteInt(params.autohinter);
reply.WriteInt(params.hinting != gfx::FontRenderParams::HINTING_NONE);
@@ -320,7 +320,7 @@ void SandboxIPCHandler::HandleGetStyleForStrike(
void SandboxIPCHandler::HandleLocaltime(
int fd,
- PickleIterator iter,
+ base::PickleIterator iter,
const std::vector<base::ScopedFD*>& fds) {
// The other side of this call is in zygote_main_linux.cc
@@ -342,7 +342,7 @@ void SandboxIPCHandler::HandleLocaltime(
time_zone_string = expanded_time->tm_zone;
}
- Pickle reply;
+ base::Pickle reply;
reply.WriteString(result_string);
reply.WriteString(time_zone_string);
SendRendererReply(fds, reply, -1);
@@ -350,7 +350,7 @@ void SandboxIPCHandler::HandleLocaltime(
void SandboxIPCHandler::HandleMakeSharedMemorySegment(
int fd,
- PickleIterator iter,
+ base::PickleIterator iter,
const std::vector<base::ScopedFD*>& fds) {
base::SharedMemoryCreateOptions options;
uint32_t size;
@@ -363,13 +363,13 @@ void SandboxIPCHandler::HandleMakeSharedMemorySegment(
base::SharedMemory shm;
if (shm.Create(options))
shm_fd = shm.handle().fd;
- Pickle reply;
+ base::Pickle reply;
SendRendererReply(fds, reply, shm_fd);
}
void SandboxIPCHandler::HandleMatchWithFallback(
int fd,
- PickleIterator iter,
+ base::PickleIterator iter,
const std::vector<base::ScopedFD*>& fds) {
std::string face;
bool is_bold, is_italic;
@@ -386,7 +386,7 @@ void SandboxIPCHandler::HandleMatchWithFallback(
int font_fd = MatchFontFaceWithFallback(
face, is_bold, is_italic, charset, fallback_family);
- Pickle reply;
+ base::Pickle reply;
SendRendererReply(fds, reply, font_fd);
if (font_fd >= 0) {
@@ -397,7 +397,7 @@ void SandboxIPCHandler::HandleMatchWithFallback(
void SandboxIPCHandler::SendRendererReply(
const std::vector<base::ScopedFD*>& fds,
- const Pickle& reply,
+ const base::Pickle& reply,
int reply_fd) {
struct msghdr msg;
memset(&msg, 0, sizeof(msg));

Powered by Google App Engine
This is Rietveld 408576698