Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: content/renderer/scheduler/resource_dispatch_throttler_unittest.cc

Issue 1154283003: Change most uses of Pickle to base::Pickle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/scheduler/resource_dispatch_throttler.h" 5 #include "content/renderer/scheduler/resource_dispatch_throttler.h"
6 6
7 #include "base/memory/scoped_vector.h" 7 #include "base/memory/scoped_vector.h"
8 #include "content/common/resource_messages.h" 8 #include "content/common/resource_messages.h"
9 #include "content/test/fake_renderer_scheduler.h" 9 #include "content/test/fake_renderer_scheduler.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
11 11
12 namespace content { 12 namespace content {
13 namespace { 13 namespace {
14 14
15 const uint32 kRequestsPerFlush = 4; 15 const uint32 kRequestsPerFlush = 4;
16 const double kFlushPeriodSeconds = 1.f / 60; 16 const double kFlushPeriodSeconds = 1.f / 60;
17 const int kRoutingId = 1; 17 const int kRoutingId = 1;
18 18
19 typedef ScopedVector<IPC::Message> ScopedMessages; 19 typedef ScopedVector<IPC::Message> ScopedMessages;
20 20
21 int GetRequestId(const IPC::Message& msg) { 21 int GetRequestId(const IPC::Message& msg) {
22 int request_id = -1; 22 int request_id = -1;
23 switch (msg.type()) { 23 switch (msg.type()) {
24 case ResourceHostMsg_RequestResource::ID: { 24 case ResourceHostMsg_RequestResource::ID: {
25 PickleIterator iter(msg); 25 base::PickleIterator iter(msg);
26 int routing_id = -1; 26 int routing_id = -1;
27 if (!iter.ReadInt(&routing_id) || !iter.ReadInt(&request_id)) 27 if (!iter.ReadInt(&routing_id) || !iter.ReadInt(&request_id))
28 NOTREACHED() << "Invalid id for resource request message."; 28 NOTREACHED() << "Invalid id for resource request message.";
29 } break; 29 } break;
30 30
31 case ResourceHostMsg_DidChangePriority::ID: 31 case ResourceHostMsg_DidChangePriority::ID:
32 case ResourceHostMsg_ReleaseDownloadedFile::ID: 32 case ResourceHostMsg_ReleaseDownloadedFile::ID:
33 case ResourceHostMsg_CancelRequest::ID: 33 case ResourceHostMsg_CancelRequest::ID:
34 if (!PickleIterator(msg).ReadInt(&request_id)) 34 if (!base::PickleIterator(msg).ReadInt(&request_id))
35 NOTREACHED() << "Invalid id for resource message."; 35 NOTREACHED() << "Invalid id for resource message.";
36 break; 36 break;
37 37
38 default: 38 default:
39 NOTREACHED() << "Invalid message for resource throttling."; 39 NOTREACHED() << "Invalid message for resource throttling.";
40 break; 40 break;
41 } 41 }
42 return request_id; 42 return request_id;
43 } 43 }
44 44
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 return sent_messages_.empty() ? nullptr : sent_messages_.back(); 165 return sent_messages_.empty() ? nullptr : sent_messages_.back();
166 } 166 }
167 167
168 int LastSentRequestId() const { 168 int LastSentRequestId() const {
169 const IPC::Message* msg = LastSentMessage(); 169 const IPC::Message* msg = LastSentMessage();
170 if (!msg) 170 if (!msg)
171 return -1; 171 return -1;
172 172
173 int routing_id = -1; 173 int routing_id = -1;
174 int request_id = -1; 174 int request_id = -1;
175 PickleIterator iter(*msg); 175 base::PickleIterator iter(*msg);
176 CHECK(IPC::ReadParam(msg, &iter, &routing_id)); 176 CHECK(IPC::ReadParam(msg, &iter, &routing_id));
177 CHECK(IPC::ReadParam(msg, &iter, &request_id)); 177 CHECK(IPC::ReadParam(msg, &iter, &request_id));
178 return request_id; 178 return request_id;
179 } 179 }
180 180
181 int last_request_id() const { return last_request_id_; } 181 int last_request_id() const { return last_request_id_; }
182 182
183 ScopedMessages sent_messages_; 183 ScopedMessages sent_messages_;
184 184
185 private: 185 private:
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
361 EXPECT_EQ(priority_msg.type(), ResourceHostMsg_DidChangePriority::ID); 361 EXPECT_EQ(priority_msg.type(), ResourceHostMsg_DidChangePriority::ID);
362 EXPECT_EQ(cancel_msg.type(), ResourceHostMsg_CancelRequest::ID); 362 EXPECT_EQ(cancel_msg.type(), ResourceHostMsg_CancelRequest::ID);
363 363
364 EXPECT_EQ(GetRequestId(request_msg), GetRequestId(priority_msg)); 364 EXPECT_EQ(GetRequestId(request_msg), GetRequestId(priority_msg));
365 EXPECT_EQ(GetRequestId(request_msg) - 1, GetRequestId(cancel_msg)); 365 EXPECT_EQ(GetRequestId(request_msg) - 1, GetRequestId(cancel_msg));
366 } 366 }
367 EXPECT_FALSE(FlushScheduled()); 367 EXPECT_FALSE(FlushScheduled());
368 } 368 }
369 369
370 } // namespace content 370 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698