Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1153003002: Returning scoped_ptr instead of raw pointer in SocketPoolInfoToValue() in net/ (Closed)

Created:
5 years, 7 months ago by payal.pandey
Modified:
5 years, 6 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Returning scoped_ptr instead of raw pointer in SocketPoolInfoToValue() in net/ BUG=472381 Committed: https://crrev.com/62a400297d375a9cd558104c5153182e0b08d80e Cr-Commit-Position: refs/heads/master@{#331760}

Patch Set 1 #

Patch Set 2 : CL Updated #

Total comments: 1

Patch Set 3 : Updated CL as directed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -27 lines) Patch
M net/http/http_network_session.h View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M net/http/http_network_session.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/socket/client_socket_pool_manager.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M net/socket/client_socket_pool_manager_impl.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M net/socket/client_socket_pool_manager_impl.cc View 1 2 chunks +9 lines, -14 lines 0 comments Download
M net/socket/mock_client_socket_pool_manager.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/socket/mock_client_socket_pool_manager.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
payal.pandey
Please have a look, Thanks.
5 years, 7 months ago (2015-05-26 12:29:02 UTC) #2
eroman
https://codereview.chromium.org/1153003002/diff/20001/net/socket/mock_client_socket_pool_manager.cc File net/socket/mock_client_socket_pool_manager.cc (right): https://codereview.chromium.org/1153003002/diff/20001/net/socket/mock_client_socket_pool_manager.cc#newcode92 net/socket/mock_client_socket_pool_manager.cc:92: scoped_ptr<base::ListValue> list(new base::ListValue()); This is not equivalent. Before it ...
5 years, 7 months ago (2015-05-26 17:46:51 UTC) #3
payal.pandey
Thanks for guidance, Update the CL as directed. > return scoped_ptr<base::Value>(nullptr); Please review.
5 years, 7 months ago (2015-05-27 06:42:32 UTC) #4
eroman
lgtm
5 years, 7 months ago (2015-05-27 18:25:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153003002/40001
5 years, 6 months ago (2015-05-28 07:26:23 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-05-28 09:30:05 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-05-28 09:31:08 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/62a400297d375a9cd558104c5153182e0b08d80e
Cr-Commit-Position: refs/heads/master@{#331760}

Powered by Google App Engine
This is Rietveld 408576698