Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Side by Side Diff: net/socket/client_socket_pool_manager.h

Issue 1153003002: Returning scoped_ptr instead of raw pointer in SocketPoolInfoToValue() in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated CL as directed. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/http/http_network_session.cc ('k') | net/socket/client_socket_pool_manager_impl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // ClientSocketPoolManager manages access to all ClientSocketPools. It's a 5 // ClientSocketPoolManager manages access to all ClientSocketPools. It's a
6 // simple container for all of them. Most importantly, it handles the lifetime 6 // simple container for all of them. Most importantly, it handles the lifetime
7 // and destruction order properly. 7 // and destruction order properly.
8 8
9 #ifndef NET_SOCKET_CLIENT_SOCKET_POOL_MANAGER_H_ 9 #ifndef NET_SOCKET_CLIENT_SOCKET_POOL_MANAGER_H_
10 #define NET_SOCKET_CLIENT_SOCKET_POOL_MANAGER_H_ 10 #define NET_SOCKET_CLIENT_SOCKET_POOL_MANAGER_H_
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 virtual void FlushSocketPoolsWithError(int error) = 0; 76 virtual void FlushSocketPoolsWithError(int error) = 0;
77 virtual void CloseIdleSockets() = 0; 77 virtual void CloseIdleSockets() = 0;
78 virtual TransportClientSocketPool* GetTransportSocketPool() = 0; 78 virtual TransportClientSocketPool* GetTransportSocketPool() = 0;
79 virtual SSLClientSocketPool* GetSSLSocketPool() = 0; 79 virtual SSLClientSocketPool* GetSSLSocketPool() = 0;
80 virtual SOCKSClientSocketPool* GetSocketPoolForSOCKSProxy( 80 virtual SOCKSClientSocketPool* GetSocketPoolForSOCKSProxy(
81 const HostPortPair& socks_proxy) = 0; 81 const HostPortPair& socks_proxy) = 0;
82 virtual HttpProxyClientSocketPool* GetSocketPoolForHTTPProxy( 82 virtual HttpProxyClientSocketPool* GetSocketPoolForHTTPProxy(
83 const HostPortPair& http_proxy) = 0; 83 const HostPortPair& http_proxy) = 0;
84 virtual SSLClientSocketPool* GetSocketPoolForSSLWithProxy( 84 virtual SSLClientSocketPool* GetSocketPoolForSSLWithProxy(
85 const HostPortPair& proxy_server) = 0; 85 const HostPortPair& proxy_server) = 0;
86 // Creates a Value summary of the state of the socket pools. The caller is 86 // Creates a Value summary of the state of the socket pools.
87 // responsible for deleting the returned value. 87 virtual scoped_ptr<base::Value> SocketPoolInfoToValue() const = 0;
88 virtual base::Value* SocketPoolInfoToValue() const = 0;
89 }; 88 };
90 89
91 // A helper method that uses the passed in proxy information to initialize a 90 // A helper method that uses the passed in proxy information to initialize a
92 // ClientSocketHandle with the relevant socket pool. Use this method for 91 // ClientSocketHandle with the relevant socket pool. Use this method for
93 // HTTP/HTTPS requests. |ssl_config_for_origin| is only used if the request 92 // HTTP/HTTPS requests. |ssl_config_for_origin| is only used if the request
94 // uses SSL and |ssl_config_for_proxy| is used if the proxy server is HTTPS. 93 // uses SSL and |ssl_config_for_proxy| is used if the proxy server is HTTPS.
95 // |resolution_callback| will be invoked after the the hostname is 94 // |resolution_callback| will be invoked after the the hostname is
96 // resolved. If |resolution_callback| does not return OK, then the 95 // resolved. If |resolution_callback| does not return OK, then the
97 // connection will be aborted with that value. 96 // connection will be aborted with that value.
98 // If |want_spdy_over_ssl| is true, then after the SSL handshake is complete, 97 // If |want_spdy_over_ssl| is true, then after the SSL handshake is complete,
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 bool want_spdy_over_npn, 182 bool want_spdy_over_npn,
184 const SSLConfig& ssl_config_for_origin, 183 const SSLConfig& ssl_config_for_origin,
185 const SSLConfig& ssl_config_for_proxy, 184 const SSLConfig& ssl_config_for_proxy,
186 PrivacyMode privacy_mode, 185 PrivacyMode privacy_mode,
187 const BoundNetLog& net_log, 186 const BoundNetLog& net_log,
188 int num_preconnect_streams); 187 int num_preconnect_streams);
189 188
190 } // namespace net 189 } // namespace net
191 190
192 #endif // NET_SOCKET_CLIENT_SOCKET_POOL_MANAGER_H_ 191 #endif // NET_SOCKET_CLIENT_SOCKET_POOL_MANAGER_H_
OLDNEW
« no previous file with comments | « net/http/http_network_session.cc ('k') | net/socket/client_socket_pool_manager_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698