Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: net/socket/mock_client_socket_pool_manager.h

Issue 1153003002: Returning scoped_ptr instead of raw pointer in SocketPoolInfoToValue() in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated CL as directed. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_SOCKET_MOCK_CLIENT_SOCKET_POOL_MANAGER_H_ 5 #ifndef NET_SOCKET_MOCK_CLIENT_SOCKET_POOL_MANAGER_H_
6 #define NET_SOCKET_MOCK_CLIENT_SOCKET_POOL_MANAGER_H_ 6 #define NET_SOCKET_MOCK_CLIENT_SOCKET_POOL_MANAGER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "net/socket/client_socket_pool_manager.h" 9 #include "net/socket/client_socket_pool_manager.h"
10 #include "net/socket/client_socket_pool_manager_impl.h" 10 #include "net/socket/client_socket_pool_manager_impl.h"
(...skipping 19 matching lines...) Expand all
30 void FlushSocketPoolsWithError(int error) override; 30 void FlushSocketPoolsWithError(int error) override;
31 void CloseIdleSockets() override; 31 void CloseIdleSockets() override;
32 TransportClientSocketPool* GetTransportSocketPool() override; 32 TransportClientSocketPool* GetTransportSocketPool() override;
33 SSLClientSocketPool* GetSSLSocketPool() override; 33 SSLClientSocketPool* GetSSLSocketPool() override;
34 SOCKSClientSocketPool* GetSocketPoolForSOCKSProxy( 34 SOCKSClientSocketPool* GetSocketPoolForSOCKSProxy(
35 const HostPortPair& socks_proxy) override; 35 const HostPortPair& socks_proxy) override;
36 HttpProxyClientSocketPool* GetSocketPoolForHTTPProxy( 36 HttpProxyClientSocketPool* GetSocketPoolForHTTPProxy(
37 const HostPortPair& http_proxy) override; 37 const HostPortPair& http_proxy) override;
38 SSLClientSocketPool* GetSocketPoolForSSLWithProxy( 38 SSLClientSocketPool* GetSocketPoolForSSLWithProxy(
39 const HostPortPair& proxy_server) override; 39 const HostPortPair& proxy_server) override;
40 base::Value* SocketPoolInfoToValue() const override; 40 scoped_ptr<base::Value> SocketPoolInfoToValue() const override;
41 41
42 private: 42 private:
43 typedef internal::OwnedPoolMap<HostPortPair, TransportClientSocketPool*> 43 typedef internal::OwnedPoolMap<HostPortPair, TransportClientSocketPool*>
44 TransportSocketPoolMap; 44 TransportSocketPoolMap;
45 typedef internal::OwnedPoolMap<HostPortPair, SOCKSClientSocketPool*> 45 typedef internal::OwnedPoolMap<HostPortPair, SOCKSClientSocketPool*>
46 SOCKSSocketPoolMap; 46 SOCKSSocketPoolMap;
47 typedef internal::OwnedPoolMap<HostPortPair, HttpProxyClientSocketPool*> 47 typedef internal::OwnedPoolMap<HostPortPair, HttpProxyClientSocketPool*>
48 HTTPProxySocketPoolMap; 48 HTTPProxySocketPoolMap;
49 typedef internal::OwnedPoolMap<HostPortPair, SSLClientSocketPool*> 49 typedef internal::OwnedPoolMap<HostPortPair, SSLClientSocketPool*>
50 SSLSocketPoolMap; 50 SSLSocketPoolMap;
51 51
52 scoped_ptr<TransportClientSocketPool> transport_socket_pool_; 52 scoped_ptr<TransportClientSocketPool> transport_socket_pool_;
53 scoped_ptr<SSLClientSocketPool> ssl_socket_pool_; 53 scoped_ptr<SSLClientSocketPool> ssl_socket_pool_;
54 SOCKSSocketPoolMap socks_socket_pools_; 54 SOCKSSocketPoolMap socks_socket_pools_;
55 HTTPProxySocketPoolMap http_proxy_socket_pools_; 55 HTTPProxySocketPoolMap http_proxy_socket_pools_;
56 SSLSocketPoolMap ssl_socket_pools_for_proxies_; 56 SSLSocketPoolMap ssl_socket_pools_for_proxies_;
57 57
58 DISALLOW_COPY_AND_ASSIGN(MockClientSocketPoolManager); 58 DISALLOW_COPY_AND_ASSIGN(MockClientSocketPoolManager);
59 }; 59 };
60 60
61 } // namespace net 61 } // namespace net
62 62
63 #endif // NET_SOCKET_MOCK_CLIENT_SOCKET_POOL_MANAGER_H_ 63 #endif // NET_SOCKET_MOCK_CLIENT_SOCKET_POOL_MANAGER_H_
OLDNEW
« no previous file with comments | « net/socket/client_socket_pool_manager_impl.cc ('k') | net/socket/mock_client_socket_pool_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698