Returning scoped_ptr instead of raw pointer in SocketPoolInfoToValue() in net/

net/socket/mock_client_socket_pool_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/socket/mock_client_socket_pool_manager.h"
 
+#include "base/values.h"
 #include "net/http/http_proxy_client_socket_pool.h"
 #include "net/socket/socks_client_socket_pool.h"
 #include "net/socket/ssl_client_socket_pool.h"
 #include "net/socket/transport_client_socket_pool.h"
 
 namespace net {
 
 MockClientSocketPoolManager::MockClientSocketPoolManager() {}
 MockClientSocketPoolManager::~MockClientSocketPoolManager() {}
 
@@ skipping 62 matching lines @@
 
 SSLClientSocketPool* MockClientSocketPoolManager::GetSocketPoolForSSLWithProxy(
     const HostPortPair& proxy_server) {
   SSLSocketPoolMap::const_iterator it =
       ssl_socket_pools_for_proxies_.find(proxy_server);
   if (it != ssl_socket_pools_for_proxies_.end())
     return it->second;
   return NULL;
 }
 
-base::Value* MockClientSocketPoolManager::SocketPoolInfoToValue() const {
+scoped_ptr<base::Value> MockClientSocketPoolManager::SocketPoolInfoToValue()
+    const {
+  scoped_ptr<base::ListValue> list(new base::ListValue());

[eroman, 2015/05/26 17:46:51]

This is not equivalent. Before it was returning NULL. A more direct translation
would be:

   return scoped_ptr<base::Value>(nullptr);

   NOTIMPLEMENTED();
-  return NULL;
+  return list.Pass();
 }
 
 }  // namespace net