net/http/http_network_session.cc - Issue 1153003002: Returning scoped_ptr instead of raw pointer in SocketPoolInfoToValue() in net/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_network_session.cc

Issue 1153003002: Returning scoped_ptr instead of raw pointer in SocketPoolInfoToValue() in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated CL as directed. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_network_session.cc

diff --git a/net/http/http_network_session.cc b/net/http/http_network_session.cc

index 521aa775be27edae4a82a05297e0b6a004eff499..c0f6cb4a6c4542b388989ac610267cfe27f9a0d5 100644

--- a/net/http/http_network_session.cc

+++ b/net/http/http_network_session.cc

@@ -250,7 +250,7 @@ SSLClientSocketPool* HttpNetworkSession::GetSocketPoolForSSLWithProxy(

proxy_server);

}

-base::Value* HttpNetworkSession::SocketPoolInfoToValue() const {

+scoped_ptr<base::Value> HttpNetworkSession::SocketPoolInfoToValue() const {

// TODO(yutak): Should merge values from normal pools and WebSocket pools.

return normal_socket_pool_manager_->SocketPoolInfoToValue();

}

« no previous file with comments | « net/http/http_network_session.h ('k') | net/socket/client_socket_pool_manager.h » ('j') | no next file with comments »