Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1354)

Unified Diff: net/socket/client_socket_pool_manager.h

Issue 1153003002: Returning scoped_ptr instead of raw pointer in SocketPoolInfoToValue() in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated CL as directed. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_network_session.cc ('k') | net/socket/client_socket_pool_manager_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/client_socket_pool_manager.h
diff --git a/net/socket/client_socket_pool_manager.h b/net/socket/client_socket_pool_manager.h
index 69d22f5a197b6dc800ec90989f0bf5ff383c6473..6b8a68e9942c3b4a4501a2734b593554bb5310ee 100644
--- a/net/socket/client_socket_pool_manager.h
+++ b/net/socket/client_socket_pool_manager.h
@@ -83,9 +83,8 @@ class NET_EXPORT_PRIVATE ClientSocketPoolManager {
const HostPortPair& http_proxy) = 0;
virtual SSLClientSocketPool* GetSocketPoolForSSLWithProxy(
const HostPortPair& proxy_server) = 0;
- // Creates a Value summary of the state of the socket pools. The caller is
- // responsible for deleting the returned value.
- virtual base::Value* SocketPoolInfoToValue() const = 0;
+ // Creates a Value summary of the state of the socket pools.
+ virtual scoped_ptr<base::Value> SocketPoolInfoToValue() const = 0;
};
// A helper method that uses the passed in proxy information to initialize a
« no previous file with comments | « net/http/http_network_session.cc ('k') | net/socket/client_socket_pool_manager_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698