Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1149773005: Add direct getter for GrCaps to GrContext. (Closed)

Created:
5 years, 6 months ago by bsalomon
Modified:
5 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : fix nanobench.cpp #

Patch Set 4 : caps in right place #

Patch Set 5 : init caps in the right place #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -116 lines) Patch
M bench/nanobench.cpp View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M include/gpu/GrContext.h View 3 chunks +4 lines, -39 lines 0 comments Download
M src/core/SkPictureShader.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkGpuBlurUtils.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/GrAddPathRenderers_default.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrBlurUtils.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 2 3 4 7 chunks +5 lines, -29 lines 0 comments Download
M src/gpu/GrCoordTransform.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDashLinePathRenderer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/gpu/GrDashLinePathRenderer.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M src/gpu/GrPathRendererChain.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/GrSWMaskHelper.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/SkGr.cpp View 6 chunks +10 lines, -7 lines 0 comments Download
M tests/GrDrawTargetTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GrPorterDuffTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ResourceCacheTest.cpp View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
bsalomon
5 years, 6 months ago (2015-05-28 00:54:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149773005/20001
5 years, 6 months ago (2015-05-28 00:55:27 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/1302)
5 years, 6 months ago (2015-05-28 00:56:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149773005/40001
5 years, 6 months ago (2015-05-28 14:47:25 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/1114)
5 years, 6 months ago (2015-05-28 14:56:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149773005/60001
5 years, 6 months ago (2015-05-28 15:07:32 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/9138c46e572085870638b6f7ad7fcdfcdf3cac99
5 years, 6 months ago (2015-05-28 15:13:22 UTC) #13
bsalomon
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/1164443002/ by bsalomon@google.com. ...
5 years, 6 months ago (2015-05-28 15:20:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149773005/80001
5 years, 6 months ago (2015-05-29 14:31:53 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149773005/80001
5 years, 6 months ago (2015-05-29 14:32:27 UTC) #19
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://skia.googlesource.com/skia/+/762286309545c8a1e4bbc05dcd1fe3085d2a1f47
5 years, 6 months ago (2015-05-29 15:02:15 UTC) #20
robertphillips
5 years, 6 months ago (2015-06-01 15:52:11 UTC) #22
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698