Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1144063002: Cleanup interface descriptors to reflect that vectors are part of loads. (Closed)

Created:
5 years, 7 months ago by mvstanton
Modified:
5 years, 7 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Cleanup interface descriptors to reflect that vectors are part of loads. Also removed ornamentation like "VectorRaw" from stub names. BUG= Committed: https://crrev.com/09aaf003a93162420de88a5449f7de6e7eb04815 Cr-Commit-Position: refs/heads/master@{#28516}

Patch Set 1 #

Patch Set 2 : Ports, mips coming. #

Patch Set 3 : Ports. #

Patch Set 4 : REBASE. #

Patch Set 5 : Fixes for test failures. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+383 lines, -415 lines) Patch
M src/arm/code-stubs-arm.cc View 1 8 chunks +26 lines, -28 lines 0 comments Download
M src/arm/debug-arm.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 2 3 10 chunks +10 lines, -10 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 8 chunks +26 lines, -28 lines 0 comments Download
M src/arm64/debug-arm64.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 2 3 10 chunks +10 lines, -10 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/code-factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/code-stubs.h View 1 2 3 4 9 chunks +15 lines, -19 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 6 chunks +24 lines, -26 lines 0 comments Download
M src/ia32/debug-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 2 3 10 chunks +10 lines, -10 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ic/access-compiler.h View 1 chunk +2 lines, -6 lines 0 comments Download
M src/ic/arm/ic-arm.cc View 1 4 chunks +8 lines, -8 lines 0 comments Download
M src/ic/arm/stub-cache-arm.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/arm64/ic-arm64.cc View 1 3 chunks +14 lines, -14 lines 0 comments Download
M src/ic/arm64/stub-cache-arm64.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/ia32/ic-ia32.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/ic/ia32/stub-cache-ia32.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/ic/ic.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ic/mips/ic-mips.cc View 1 2 4 chunks +8 lines, -8 lines 0 comments Download
M src/ic/mips/stub-cache-mips.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/mips64/ic-mips64.cc View 1 2 4 chunks +8 lines, -8 lines 0 comments Download
M src/ic/mips64/stub-cache-mips64.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/x64/ic-x64.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M src/ic/x64/stub-cache-x64.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/interface-descriptors.h View 3 chunks +5 lines, -15 lines 0 comments Download
M src/interface-descriptors.cc View 2 chunks +7 lines, -12 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 2 8 chunks +25 lines, -27 lines 0 comments Download
M src/mips/debug-mips.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 2 3 10 chunks +10 lines, -10 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 2 8 chunks +25 lines, -27 lines 0 comments Download
M src/mips64/debug-mips64.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 2 3 10 chunks +10 lines, -10 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips64/lithium-mips64.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M src/runtime.js View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 1 7 chunks +26 lines, -28 lines 0 comments Download
M src/x64/debug-x64.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 3 10 chunks +10 lines, -10 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/compiler/function-tester.h View 1 2 3 4 2 chunks +9 lines, -1 line 0 comments Download
M test/cctest/compiler/test-run-stubs.cc View 1 2 3 4 2 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
mvstanton
Hi Yang, here is the cleanup CL, thx for the look, --Michael
5 years, 7 months ago (2015-05-20 08:54:12 UTC) #2
Yang
On 2015/05/20 08:54:12, mvstanton wrote: > Hi Yang, here is the cleanup CL, thx for ...
5 years, 7 months ago (2015-05-20 09:18:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144063002/40001
5 years, 7 months ago (2015-05-20 09:34:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/2825)
5 years, 7 months ago (2015-05-20 09:48:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144063002/80001
5 years, 7 months ago (2015-05-20 12:37:10 UTC) #11
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 7 months ago (2015-05-20 13:19:23 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 13:19:33 UTC) #13
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/09aaf003a93162420de88a5449f7de6e7eb04815
Cr-Commit-Position: refs/heads/master@{#28516}

Powered by Google App Engine
This is Rietveld 408576698