Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: src/ic/arm/stub-cache-arm.cc

Issue 1144063002: Cleanup interface descriptors to reflect that vectors are part of loads. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixes for test failures. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/arm/ic-arm.cc ('k') | src/ic/arm64/ic-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/ic/ic.h" 10 #include "src/ic/ic.h"
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 DCHECK(!scratch.is(no_reg)); 118 DCHECK(!scratch.is(no_reg));
119 DCHECK(!extra.is(no_reg)); 119 DCHECK(!extra.is(no_reg));
120 DCHECK(!extra2.is(no_reg)); 120 DCHECK(!extra2.is(no_reg));
121 DCHECK(!extra3.is(no_reg)); 121 DCHECK(!extra3.is(no_reg));
122 122
123 #ifdef DEBUG 123 #ifdef DEBUG
124 // If vector-based ics are in use, ensure that scratch, extra, extra2 and 124 // If vector-based ics are in use, ensure that scratch, extra, extra2 and
125 // extra3 don't conflict with the vector and slot registers, which need 125 // extra3 don't conflict with the vector and slot registers, which need
126 // to be preserved for a handler call or miss. 126 // to be preserved for a handler call or miss.
127 if (IC::ICUseVector(ic_kind)) { 127 if (IC::ICUseVector(ic_kind)) {
128 Register vector = VectorLoadICDescriptor::VectorRegister(); 128 Register vector = LoadWithVectorDescriptor::VectorRegister();
129 Register slot = VectorLoadICDescriptor::SlotRegister(); 129 Register slot = LoadWithVectorDescriptor::SlotRegister();
130 DCHECK(!AreAliased(vector, slot, scratch, extra, extra2, extra3)); 130 DCHECK(!AreAliased(vector, slot, scratch, extra, extra2, extra3));
131 } 131 }
132 #endif 132 #endif
133 133
134 Counters* counters = masm->isolate()->counters(); 134 Counters* counters = masm->isolate()->counters();
135 __ IncrementCounter(counters->megamorphic_stub_cache_probes(), 1, extra2, 135 __ IncrementCounter(counters->megamorphic_stub_cache_probes(), 1, extra2,
136 extra3); 136 extra3);
137 137
138 // Check that the receiver isn't a smi. 138 // Check that the receiver isn't a smi.
139 __ JumpIfSmi(receiver, &miss); 139 __ JumpIfSmi(receiver, &miss);
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 __ IncrementCounter(counters->megamorphic_stub_cache_misses(), 1, extra2, 172 __ IncrementCounter(counters->megamorphic_stub_cache_misses(), 1, extra2,
173 extra3); 173 extra3);
174 } 174 }
175 175
176 176
177 #undef __ 177 #undef __
178 } 178 }
179 } // namespace v8::internal 179 } // namespace v8::internal
180 180
181 #endif // V8_TARGET_ARCH_ARM 181 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/ic/arm/ic-arm.cc ('k') | src/ic/arm64/ic-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698