Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: src/ic/ia32/stub-cache-ia32.cc

Issue 1144063002: Cleanup interface descriptors to reflect that vectors are part of loads. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixes for test failures. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/ia32/ic-ia32.cc ('k') | src/ic/ic.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/ic/ic.h" 10 #include "src/ic/ic.h"
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 if (FLAG_test_secondary_stub_cache && table == StubCache::kPrimary) { 54 if (FLAG_test_secondary_stub_cache && table == StubCache::kPrimary) {
55 __ jmp(&miss); 55 __ jmp(&miss);
56 } else if (FLAG_test_primary_stub_cache && table == StubCache::kSecondary) { 56 } else if (FLAG_test_primary_stub_cache && table == StubCache::kSecondary) {
57 __ jmp(&miss); 57 __ jmp(&miss);
58 } 58 }
59 #endif 59 #endif
60 60
61 if (IC::ICUseVector(ic_kind)) { 61 if (IC::ICUseVector(ic_kind)) {
62 // The vector and slot were pushed onto the stack before starting the 62 // The vector and slot were pushed onto the stack before starting the
63 // probe, and need to be dropped before calling the handler. 63 // probe, and need to be dropped before calling the handler.
64 __ pop(VectorLoadICDescriptor::VectorRegister()); 64 __ pop(LoadWithVectorDescriptor::VectorRegister());
65 __ pop(VectorLoadICDescriptor::SlotRegister()); 65 __ pop(LoadDescriptor::SlotRegister());
66 } 66 }
67 67
68 if (leave_frame) __ leave(); 68 if (leave_frame) __ leave();
69 69
70 // Jump to the first instruction in the code stub. 70 // Jump to the first instruction in the code stub.
71 __ add(extra, Immediate(Code::kHeaderSize - kHeapObjectTag)); 71 __ add(extra, Immediate(Code::kHeaderSize - kHeapObjectTag));
72 __ jmp(extra); 72 __ jmp(extra);
73 73
74 __ bind(&miss); 74 __ bind(&miss);
75 } else { 75 } else {
(...skipping 29 matching lines...) Expand all
105 } 105 }
106 #endif 106 #endif
107 107
108 // Restore offset and re-load code entry from cache. 108 // Restore offset and re-load code entry from cache.
109 __ pop(offset); 109 __ pop(offset);
110 __ mov(offset, Operand::StaticArray(offset, times_1, value_offset)); 110 __ mov(offset, Operand::StaticArray(offset, times_1, value_offset));
111 111
112 if (IC::ICUseVector(ic_kind)) { 112 if (IC::ICUseVector(ic_kind)) {
113 // The vector and slot were pushed onto the stack before starting the 113 // The vector and slot were pushed onto the stack before starting the
114 // probe, and need to be dropped before calling the handler. 114 // probe, and need to be dropped before calling the handler.
115 Register vector = VectorLoadICDescriptor::VectorRegister(); 115 Register vector = LoadWithVectorDescriptor::VectorRegister();
116 Register slot = VectorLoadICDescriptor::SlotRegister(); 116 Register slot = LoadDescriptor::SlotRegister();
117 DCHECK(!offset.is(vector) && !offset.is(slot)); 117 DCHECK(!offset.is(vector) && !offset.is(slot));
118 118
119 __ pop(vector); 119 __ pop(vector);
120 __ pop(slot); 120 __ pop(slot);
121 } 121 }
122 122
123 if (leave_frame) __ leave(); 123 if (leave_frame) __ leave();
124 124
125 // Jump to the first instruction in the code stub. 125 // Jump to the first instruction in the code stub.
126 __ add(offset, Immediate(Code::kHeaderSize - kHeapObjectTag)); 126 __ add(offset, Immediate(Code::kHeaderSize - kHeapObjectTag));
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
201 __ bind(&miss); 201 __ bind(&miss);
202 __ IncrementCounter(counters->megamorphic_stub_cache_misses(), 1); 202 __ IncrementCounter(counters->megamorphic_stub_cache_misses(), 1);
203 } 203 }
204 204
205 205
206 #undef __ 206 #undef __
207 } 207 }
208 } // namespace v8::internal 208 } // namespace v8::internal
209 209
210 #endif // V8_TARGET_ARCH_IA32 210 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ic/ia32/ic-ia32.cc ('k') | src/ic/ic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698