Issue 11434046: Android rayshader sample.

Issue 11434046: Android rayshader sample. (Closed)

Created:
8 years ago by gram

Modified:
8 years ago

Reviewers:
vsm, Cutch

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Android rayshader sample. Committed: https://code.google.com/p/dart/source/detail?r=15606

Patch Set 8 : #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4990 lines, -0 lines)			Patch
M	dart.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	samples/android_sample/AndroidManifest.xml	View		1 chunk	+33 lines, -0 lines	0 comments	Download
A	samples/android_sample/android_sample.gyp	View	1	1 chunk	+38 lines, -0 lines	0 comments	Download
A	samples/android_sample/assets/dart/android_extension.dart	View	1	1 chunk	+143 lines, -0 lines	0 comments	Download
A	samples/android_sample/assets/dart/main.dart	View	1 2 3 4	1 chunk	+358 lines, -0 lines	0 comments	Download
A	samples/android_sample/build.xml	View		1 chunk	+92 lines, -0 lines	0 comments	Download
A	samples/android_sample/custom_rules.xml	View	1 2	1 chunk	+38 lines, -0 lines	0 comments	Download
A	samples/android_sample/ic_launcher.png-hdpi.hex	View		1 chunk	+514 lines, -0 lines	0 comments	Download
A	samples/android_sample/ic_launcher.png-ldpi.hex	View		1 chunk	+160 lines, -0 lines	0 comments	Download
A	samples/android_sample/ic_launcher.png-mdpi.hex	View		1 chunk	+254 lines, -0 lines	0 comments	Download
A	samples/android_sample/ic_launcher.png-xhdpi.hex	View		1 chunk	+848 lines, -0 lines	0 comments	Download
A	samples/android_sample/jni/Android.mk	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
A	samples/android_sample/jni/AndroidEmbedder.mk	View	1 2 3 4 5 6 7	1 chunk	+8 lines, -0 lines	0 comments	Download
A	samples/android_sample/jni/AndroidExtension.mk	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
A	samples/android_sample/jni/Application.mk	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
A	samples/android_sample/jni/DartNDK.mk	View	1 2 3 4	1 chunk	+17 lines, -0 lines	0 comments	Download
A	samples/android_sample/jni/activity_handler.h	View	1 2 3 4	1 chunk	+25 lines, -0 lines	0 comments	Download
A	samples/android_sample/jni/android_extension.cc	View	1 2 3 4 5 6	1 chunk	+1188 lines, -0 lines	0 comments	Download
A	samples/android_sample/jni/context.h	View	1 2 3 4	1 chunk	+17 lines, -0 lines	0 comments	Download
A	samples/android_sample/jni/dart_host.h	View	1 2 3 4	1 chunk	+58 lines, -0 lines	0 comments	Download
A	samples/android_sample/jni/dart_host.cc	View	1 2 3 4 5 6	1 chunk	+126 lines, -0 lines	0 comments	Download
A	samples/android_sample/jni/eventloop.h	View	1 2 3 4 5	1 chunk	+32 lines, -0 lines	0 comments	Download
A	samples/android_sample/jni/eventloop.cc	View	1 2 3 4 5	1 chunk	+144 lines, -0 lines	0 comments	Download
A	samples/android_sample/jni/graphics.h	View	1 2 3 4 5 6	1 chunk	+29 lines, -0 lines	0 comments	Download
A	samples/android_sample/jni/graphics.cc	View	1 2 3 4 5	1 chunk	+92 lines, -0 lines	0 comments	Download
A	samples/android_sample/jni/input_handler.h	View	1 2 3 4 5	1 chunk	+15 lines, -0 lines	0 comments	Download
A	samples/android_sample/jni/input_service.h	View	1 2 3 4 5	1 chunk	+28 lines, -0 lines	0 comments	Download
A	samples/android_sample/jni/input_service.cc	View	1 2 3 4 5	1 chunk	+118 lines, -0 lines	0 comments	Download
A	samples/android_sample/jni/main.cc	View	1 2 3 4 5	1 chunk	+20 lines, -0 lines	0 comments	Download
A	samples/android_sample/jni/timer.h	View	1 2 3 4	1 chunk	+20 lines, -0 lines	0 comments	Download
A	samples/android_sample/jni/timer.cc	View	1 2 3 4 5	1 chunk	+27 lines, -0 lines	0 comments	Download
A	samples/android_sample/jni/types.h	View	1 2 3 4 5	1 chunk	+19 lines, -0 lines	0 comments	Download
A	samples/android_sample/jni/vm_glue.h	View	1 2 3 4 5	1 chunk	+46 lines, -0 lines	0 comments	Download
A	samples/android_sample/jni/vm_glue.cc	View	1 2 3 4 5	1 chunk	+355 lines, -0 lines	0 comments	Download
A	samples/android_sample/project.properties	View		1 chunk	+21 lines, -0 lines	0 comments	Download
A	samples/android_sample/res/values/strings.xml	View		1 chunk	+8 lines, -0 lines	0 comments	Download
A	samples/android_sample/res/values/styles.xml	View		1 chunk	+20 lines, -0 lines	0 comments	Download
A	samples/android_sample/src/com/google/dartndk/DummyActivity.java	View		1 chunk	+47 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

vsm

Nice! https://codereview.chromium.org/11434046/diff/1/dart.gyp File dart.gyp (left): https://codereview.chromium.org/11434046/diff/1/dart.gyp#oldcode44 dart.gyp:44: '<!@(["python", "tools/list_files.py", "", "sdk/bin"])', Did you really mean ...

8 years ago (2012-11-30 17:00:30 UTC) #2

Cutch

DBC https://codereview.chromium.org/11434046/diff/1/samples/android_sample/assets/dart/main.dart File samples/android_sample/assets/dart/main.dart (right): https://codereview.chromium.org/11434046/diff/1/samples/android_sample/assets/dart/main.dart#newcode228 samples/android_sample/assets/dart/main.dart:228: } You should be using vector_math instead of ...

8 years ago (2012-11-30 17:04:58 UTC) #3

gram

PTAL https://codereview.chromium.org/11434046/diff/1/dart.gyp File dart.gyp (left): https://codereview.chromium.org/11434046/diff/1/dart.gyp#oldcode44 dart.gyp:44: '<!@(["python", "tools/list_files.py", "", "sdk/bin"])', On 2012/11/30 17:00:30, vsm ...

8 years ago (2012-11-30 18:01:31 UTC) #4

vsm

Another pass. I noticed a lot of lint errors on rietveld as well for c++ ...

8 years ago (2012-11-30 18:38:31 UTC) #5

gram

PTAL. I have also addressed the C++ style to make it Googley, got rid of ...

8 years ago (2012-11-30 22:09:22 UTC) #6

PTAL. I have also addressed the C++ style to make it Googley, got rid of almost
all the lint issues (the remaining four are okay/expected), and fixed the
AndroidEmbedder.mk file to work for release or debug builds.

https://codereview.chromium.org/11434046/diff/1/samples/android_sample/Androi...
File samples/android_sample/AndroidManifest.xml (right):

https://codereview.chromium.org/11434046/diff/1/samples/android_sample/Androi...
samples/android_sample/AndroidManifest.xml:21: android:name="DummyActivity"
On 2012/11/30 18:38:31, vsm wrote:
> Your call.
> 
> On 2012/11/30 18:01:31, gram wrote:
> > On 2012/11/30 17:00:30, vsm wrote:
> > > We should probably give this a better name, but we can always change it. 
> :-)
> > 
> > It is a dummy in that it never gets used; it just has some static
construction
> > code that loads the native shared libraries. We could give it a long name
like
> > 'DummyActivityToLoadNativeLibraries' :-)
> > 
> > 
> 

I'll leave it for now.

https://codereview.chromium.org/11434046/diff/1/samples/android_sample/assets...
File samples/android_sample/assets/dart/main.dart (right):

https://codereview.chromium.org/11434046/diff/1/samples/android_sample/assets...
samples/android_sample/assets/dart/main.dart:344: onMotionDown(double when, int
x, int y) {
On 2012/11/30 18:38:31, vsm wrote:
> The style guide suggests that we do:
> http://www.dartlang.org/articles/style-guide/#type-annotations
> 
> But, it's not mandated, so up to you.
> 
> On 2012/11/30 18:01:31, gram wrote:
> > On 2012/11/30 17:00:30, vsm wrote:
> > > We typically use "num" instead of "double" so you can pass in int values
as
> > well
> > > (unless it's perf sensitive).
> > 
> > The NDK event is providing a double and this mirrors that. Based on that do
> you
> > still think I should make it a num?
> > 
> 

Well, it turned out I had the doubles and ints mixed up anyway; when is an int
and x,y are doubles! So I'll make 'em nums and then I can't go wrong, can I? ;-)

https://codereview.chromium.org/11434046/diff/12039/samples/android_sample/jn...
File samples/android_sample/jni/android_extension.cc (right):

https://codereview.chromium.org/11434046/diff/12039/samples/android_sample/jn...
samples/android_sample/jni/android_extension.cc:38: int y = *(int*)x;
On 2012/11/30 18:38:31, vsm wrote:
> You can get rid of this.  I used this to force a stack trace on any error
before
> you added logging.  :-)

Done.

lgtm

Expand Messages | Collapse Messages