Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1140033004: Merge V8 API updates to xfa branch (Closed)

Created:
5 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 7 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge V8 API updates to xfa branch Set pointers in internal fields directly instead of wrapping them Review URL: https://codereview.chromium.org/1139853003 Use phantom handles instead of weak handles Review URL: https://codereview.chromium.org/1129253004 Replace deprecated with non-deprecated V8 APIs Review URL: https://codereview.chromium.org/1126203010 Add myself to OWNERS file Review URL: https://codereview.chromium.org/1133333005 Replace v8::Handle with v8::Local and v8::Persistent with v8::Global Review URL: https://codereview.chromium.org/1138823004 TBR=tsepez@chromium.org BUG= Committed: https://pdfium.googlesource.com/pdfium/+/dfa2c9939a85ad1c01ef858b21942ab3773dcf27

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+356 lines, -325 lines) Patch
M OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Define.h View 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Object.h View 2 chunks +2 lines, -1 line 0 comments Download
M fpdfsdk/include/javascript/JS_Runtime.h View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Value.h View 10 chunks +14 lines, -14 lines 0 comments Download
M fpdfsdk/include/javascript/global.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/jsapi/fxjs_v8.h View 2 chunks +57 lines, -56 lines 0 comments Download
M fpdfsdk/src/fpdfxfa/fpdfxfa_app.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/Document.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Object.cpp View 2 chunks +18 lines, -9 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Value.cpp View 24 chunks +34 lines, -33 lines 0 comments Download
M fpdfsdk/src/javascript/app.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/javascript/global.cpp View 14 chunks +22 lines, -23 lines 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8.cpp View 19 chunks +164 lines, -146 lines 0 comments Download
M xfa/src/fxjse/src/class.h View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/src/fxjse/src/class.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fxjse/src/context.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxjse/src/context.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M xfa/src/fxjse/src/dynprop.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/src/fxjse/src/runtime.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxjse/src/util_inline.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxjse/src/value.h View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/src/fxjse/src/value.cpp View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jochen (gone - plz use gerrit)
Committed patchset #1 (id:1) manually as dfa2c9939a85ad1c01ef858b21942ab3773dcf27 (presubmit successful).
5 years, 7 months ago (2015-05-18 22:38:08 UTC) #1
Tom Sepez
5 years, 7 months ago (2015-05-18 22:44:30 UTC) #2
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698