Issue 1138823004: Replace v8::Handle with v8::Local and v8::Persistent with v8::Global

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1138823004: Replace v8::Handle with v8::Local and v8::Persistent with v8::Global (Closed)

Created:
5 years, 7 months ago by jochen (gone - plz use gerrit)

Modified:
5 years, 7 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Replace v8::Handle with v8::Local and v8::Persistent with v8::Global those types are just aliases, and we should consistently use the new version R=tsepez@chromium.org BUG= Committed: https://pdfium.googlesource.com/pdfium/+/3fea540931b6b2c700c50809a3d4d8a506f4f797

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+211 lines, -211 lines)			Patch
M	fpdfsdk/include/javascript/JS_Define.h	View	10 chunks	+10 lines, -10 lines	0 comments	Download
M	fpdfsdk/include/javascript/JS_Object.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/include/javascript/JS_Runtime.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	fpdfsdk/include/javascript/JS_Value.h	View	10 chunks	+14 lines, -14 lines	0 comments	Download
M	fpdfsdk/include/javascript/global.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	fpdfsdk/include/jsapi/fxjs_v8.h	View	2 chunks	+56 lines, -56 lines	0 comments	Download
M	fpdfsdk/src/javascript/Document.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Runtime.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Value.cpp	View	13 chunks	+17 lines, -17 lines	0 comments	Download
M	fpdfsdk/src/javascript/app.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	fpdfsdk/src/javascript/global.cpp	View	12 chunks	+17 lines, -17 lines	0 comments	Download
M	fpdfsdk/src/jsapi/fxjs_v8.cpp	View	27 chunks	+83 lines, -83 lines	0 comments	Download

Total messages: 4 (0 generated)

jochen (gone - plz use gerrit)

i'll merge all API changes to xfa after this one ptal

5 years, 7 months ago (2015-05-17 12:05:44 UTC) #2

jochen (gone - plz use gerrit)

5 years, 7 months ago (2015-05-18 22:33:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3fea540931b6b2c700c50809a3d4d8a506f4f797 (presubmit successful).