Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1487)

Unified Diff: xfa/src/fxjse/src/context.cpp

Issue 1140033004: Merge V8 API updates to xfa branch (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « xfa/src/fxjse/src/context.h ('k') | xfa/src/fxjse/src/dynprop.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/src/fxjse/src/context.cpp
diff --git a/xfa/src/fxjse/src/context.cpp b/xfa/src/fxjse/src/context.cpp
index f2d979ee5595bf491a3dbcf578ff918d8f9e9c1f..d78729fc35c13c3824b2ff69e6bb170795ce4661 100644
--- a/xfa/src/fxjse/src/context.cpp
+++ b/xfa/src/fxjse/src/context.cpp
@@ -63,12 +63,12 @@ FX_BOOL FXJSE_ExecuteScript(FXJSE_HCONTEXT hContext, FX_LPCSTR szScript, FXJSE_H
ASSERT(pContext);
return pContext->ExecuteScript(szScript, reinterpret_cast<CFXJSE_Value*>(hRetValue), reinterpret_cast<CFXJSE_Value*>(hNewThisObject));
}
-v8::Handle<v8::Object> FXJSE_CreateReturnValue(v8::Isolate* pIsolate, v8::TryCatch& trycatch)
+v8::Local<v8::Object> FXJSE_CreateReturnValue(v8::Isolate* pIsolate, v8::TryCatch& trycatch)
{
- v8::Handle<v8::Object> hReturnValue = v8::Object::New(pIsolate);
+ v8::Local<v8::Object> hReturnValue = v8::Object::New(pIsolate);
if (trycatch.HasCaught()) {
- v8::Handle<v8::Value> hException = trycatch.Exception();
- v8::Handle<v8::Message> hMessage = trycatch.Message();
+ v8::Local<v8::Value> hException = trycatch.Exception();
+ v8::Local<v8::Message> hMessage = trycatch.Message();
if (hException->IsObject()) {
v8::Local<v8::Value> hValue;
hValue = hException.As<v8::Object>()->Get(v8::String::NewFromUtf8(pIsolate, "name"));
@@ -207,7 +207,7 @@ FX_BOOL CFXJSE_Context::ExecuteScript(FX_LPCSTR szScript, CFXJSE_Value* lpRetVal
ASSERT(hWrapperValue->IsFunction());
v8::Local<v8::Function> hWrapperFn = hWrapperValue.As<v8::Function>();
if(!trycatch.HasCaught()) {
- v8::Handle<v8::Value> rgArgs[] = {hScriptString};
+ v8::Local<v8::Value> rgArgs[] = {hScriptString};
v8::Local<v8::Value> hValue = hWrapperFn->Call(hNewThis.As<v8::Object>(), 1, rgArgs);
if(!trycatch.HasCaught()) {
if(lpRetValue) {
« no previous file with comments | « xfa/src/fxjse/src/context.h ('k') | xfa/src/fxjse/src/dynprop.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698