Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1139853003: Set pointers in internal fields directly instead of wrapping them (Closed)

Created:
5 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 7 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Set pointers in internal fields directly instead of wrapping them The internal fields are scanned by the garbage collector, so they can't contain arbitrary data. However, aligned pointers are supported by the V8 GC, so the V8 API allows for setting a pointer directly instead of wrapping it in an External container. Not only is this faster, but it's also required for the new v8::Global API which I'm going to update to in a follow-up patch. R=tsepez@chromium.org BUG= Committed: https://pdfium.googlesource.com/pdfium/+/2a47d8d6eef22d117ac3475e84c3a52b5ca41a3c

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -19 lines) Patch
M fpdfsdk/src/jsapi/fxjs_v8.cpp View 1 2 6 chunks +9 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
5 years, 7 months ago (2015-05-12 07:01:12 UTC) #1
Tom Sepez
Can we get more information in the CL description about why this change is safe, ...
5 years, 7 months ago (2015-05-12 15:24:50 UTC) #2
jochen (gone - plz use gerrit)
5 years, 7 months ago (2015-05-13 00:31:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
2a47d8d6eef22d117ac3475e84c3a52b5ca41a3c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698