Issue 1126203010: Replace deprecated with non-deprecated V8 APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1126203010: Replace deprecated with non-deprecated V8 APIs (Closed)

Created:
5 years, 7 months ago by jochen (gone - plz use gerrit)

Modified:
5 years, 7 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Replace deprecated with non-deprecated V8 APIs In most cases, we just CHECK() that no exception was thrown. Previously, we'd just crash. Ideally, this should all be fixed and the system should cope with those exceptions, but that's beyond this CL. R=tsepez@chromium.org BUG= Committed: https://pdfium.googlesource.com/pdfium/+/d94df885e9e680e7dc8a5ac116c8d4ab5e4790cd

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+120 lines, -95 lines)			Patch
M	fpdfsdk/include/jsapi/fxjs_v8.h	View	3 chunks	+10 lines, -10 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Value.cpp	View	15 chunks	+20 lines, -19 lines	0 comments	Download
M	fpdfsdk/src/javascript/global.cpp	View	4 chunks	+6 lines, -7 lines	0 comments	Download
M	fpdfsdk/src/jsapi/fxjs_v8.cpp	View	19 chunks	+84 lines, -59 lines	0 comments	Download

Total messages: 3 (0 generated)

Tom Sepez

LGTM. Can you be sure that these also get merged into the XFA branch? (eg. ...

5 years, 7 months ago (2015-05-15 15:08:52 UTC) #2

jochen (gone - plz use gerrit)

5 years, 7 months ago (2015-05-17 11:07:14 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d94df885e9e680e7dc8a5ac116c8d4ab5e4790cd (presubmit successful).