xfa/src/fxjse/src/value.h - Issue 1140033004: Merge V8 API updates to xfa branch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fxjse/src/value.h

Issue 1140033004: Merge V8 API updates to xfa branch (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fxjse/src/value.h

diff --git a/xfa/src/fxjse/src/value.h b/xfa/src/fxjse/src/value.h

index eb118fd5c6fd886dd120f3d492de921f8823aa63..547ae9251f1a73ab81f0587631db2ecbab39132c 100644

--- a/xfa/src/fxjse/src/value.h

+++ b/xfa/src/fxjse/src/value.h

@@ -209,7 +209,7 @@ public:

{

return m_pIsolate;

}

- V8_INLINE const v8::Persistent<v8::Value>& DirectGetValue() const

+ V8_INLINE const v8::Global<v8::Value>& DirectGetValue() const

{

return m_hValue;

}

@@ -229,7 +229,7 @@ public:

static CFXJSE_Value* Create(v8::Isolate* pIsolate);

protected:

v8::Isolate* m_pIsolate;

- v8::Persistent<v8::Value> m_hValue;

+ v8::Global<v8::Value> m_hValue;

friend class CFXJSE_Context;

friend class CFXJSE_Class;

};

« no previous file with comments | « xfa/src/fxjse/src/util_inline.h ('k') | xfa/src/fxjse/src/value.cpp » ('j') | no next file with comments »