Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 11364044: cc: Replace WebCore::FloatQuad with gfx::QuadF. (Closed)

Created:
8 years, 1 month ago by danakj
Modified:
8 years, 1 month ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Replace WebCore::FloatQuad with gfx::QuadF. It does as it says it does. This depends on the QuadF CL found at https://codereview.chromium.org/11369043/ and is just search/replace after that, as I added all the equivalent functionality to QuadF that we made use of on FloatQuad. It is possible we may see some slight differences in behaviour from using FloatQuad, as we should benefit from increased precision, using doubles after multiplying floats, when using Contains(Point) or IsCounterClockwise(). Covered by existing tests; no dramatic change in behaviour. R=enne BUG=147395 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=165735

Patch Set 1 #

Patch Set 2 : Reeebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -181 lines) Patch
M cc/cc.gyp View 1 2 chunks +0 lines, -2 lines 0 comments Download
M cc/damage_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/float_quad_unittest.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M cc/gl_renderer.h View 4 chunks +4 lines, -3 lines 0 comments Download
M cc/gl_renderer.cc View 1 11 chunks +16 lines, -15 lines 0 comments Download
M cc/layer_quad.h View 3 chunks +7 lines, -3 lines 0 comments Download
M cc/layer_quad.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M cc/layer_quad_unittest.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M cc/layer_sorter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layer_sorter.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M cc/layer_sorter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layer_tree_host_common_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layer_tree_host_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/math_util.h View 2 chunks +4 lines, -4 lines 0 comments Download
M cc/math_util.cc View 8 chunks +16 lines, -16 lines 0 comments Download
M cc/occlusion_tracker.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/occlusion_tracker.cc View 4 chunks +9 lines, -7 lines 0 comments Download
M cc/overdraw_metrics.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M cc/renderer.h View 1 chunk +0 lines, -1 line 0 comments Download
D cc/stubs/float_quad.h View 1 chunk +0 lines, -87 lines 0 comments Download
M cc/tiled_layer_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
danakj
8 years, 1 month ago (2012-11-02 04:54:16 UTC) #1
enne (OOO)
lgtm
8 years, 1 month ago (2012-11-02 16:35:40 UTC) #2
commit-bot: I haz the power
8 years, 1 month ago (2012-11-02 17:52:30 UTC) #3

Powered by Google App Engine
This is Rietveld 408576698