Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1132053002: [WIP]Oilpan: checking for nearly-dead observers. (Closed)

Created:
5 years, 7 months ago by sof
Modified:
5 years, 6 months ago
Reviewers:
haraken
CC:
blink-reviews, oilpan-reviews, Mads Ager (chromium), sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, haraken, kouhei+heap_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[WIP]Oilpan: checking for nearly-dead observers.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -21 lines) Patch
M Source/core/dom/ContextLifecycleNotifier.cpp View 6 chunks +24 lines, -0 lines 1 comment Download
M Source/core/dom/DocumentLifecycleNotifier.cpp View 1 chunk +10 lines, -2 lines 0 comments Download
M Source/core/frame/DOMWindowLifecycleNotifier.cpp View 1 chunk +18 lines, -3 lines 0 comments Download
M Source/core/frame/LocalFrameLifecycleNotifier.cpp View 1 chunk +6 lines, -1 line 0 comments Download
M Source/core/page/PageLifecycleNotifier.cpp View 1 chunk +12 lines, -2 lines 0 comments Download
M Source/platform/LifecycleContextTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/LifecycleNotifier.h View 6 chunks +39 lines, -4 lines 0 comments Download
M Source/platform/LifecycleObserver.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/heap/Heap.h View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
haraken
5 years, 7 months ago (2015-05-09 14:50:33 UTC) #2
Thanks for the CL.

IMHO, I think it would be OK to add this complexity because:

- The added code is a temporary one -- it will be removed when shipping Oilpan
for the Node hierarchy.

- I cannot come up with any other idea to enable lazy sweeping (which is needed
to achieve acceptable performance for core/animations/, html/canvas/ etc). If we
don't enable lazy sweeping, we cannot enable oilpan for core/animations/,
html/canvas/ etc until we enable oilpan for the Node hierarchy. This means that
we have to enable oilpan for a ton of things in one go, which sounds risky.

Overall, I think it would be reasonable to land this CL, enable lazy sweeping,
and enable oilpan for core/animations/, html/canvas/ etc more incrementally.

https://codereview.chromium.org/1132053002/diff/1/Source/core/dom/ContextLife...
File Source/core/dom/ContextLifecycleNotifier.cpp (right):

https://codereview.chromium.org/1132053002/diff/1/Source/core/dom/ContextLife...
Source/core/dom/ContextLifecycleNotifier.cpp:46: // FIXME: Oilpan: At the
moment, it's possible that a ActiveDOMObject

Not related to this CL, I think this FIXME is valid only in non-oilpan. In
oilpan, the observers are guaranteed to be kept alive during the iteration.

Powered by Google App Engine
This is Rietveld 408576698