Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: Source/platform/LifecycleObserver.h

Issue 1132053002: [WIP]Oilpan: checking for nearly-dead observers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/LifecycleObserver.h
diff --git a/Source/platform/LifecycleObserver.h b/Source/platform/LifecycleObserver.h
index f1d6f788fce07a135cc5580d9878a3c79b5729a4..0174d2ca4802dc30b6b93d5a9dbadf63223202a2 100644
--- a/Source/platform/LifecycleObserver.h
+++ b/Source/platform/LifecycleObserver.h
@@ -75,12 +75,12 @@ template<typename T, typename Observer, typename Notifier>
inline void LifecycleObserver<T, Observer, Notifier>::setContext(typename LifecycleObserver<T, Observer, Notifier>::Context* context)
{
if (m_lifecycleContext)
- static_cast<Notifier*>(m_lifecycleContext.get())->removeObserver(static_cast<Observer*>(this));
+ static_cast<Notifier*>(m_lifecycleContext.get())->removeObserver(static_cast<Observer*>(this), IsGarbageCollectedType<T>::value);
m_lifecycleContext = context;
if (m_lifecycleContext)
- static_cast<Notifier*>(m_lifecycleContext.get())->addObserver(static_cast<Observer*>(this));
+ static_cast<Notifier*>(m_lifecycleContext.get())->addObserver(static_cast<Observer*>(this), IsGarbageCollectedType<T>::value);
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698