Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Unified Diff: Source/core/frame/LocalFrameLifecycleNotifier.cpp

Issue 1132053002: [WIP]Oilpan: checking for nearly-dead observers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/LocalFrameLifecycleNotifier.cpp
diff --git a/Source/core/frame/LocalFrameLifecycleNotifier.cpp b/Source/core/frame/LocalFrameLifecycleNotifier.cpp
index 434cf8bc2c36ffdc0ddd766b23b124726e87aeca..7208ca3ca180c9245e92acf860ef600c060b17c5 100644
--- a/Source/core/frame/LocalFrameLifecycleNotifier.cpp
+++ b/Source/core/frame/LocalFrameLifecycleNotifier.cpp
@@ -12,8 +12,13 @@ namespace blink {
void LocalFrameLifecycleNotifier::notifyWillDetachFrameHost()
{
TemporaryChange<IterationType> scope(m_iterating, IteratingOverAll);
- for (LocalFrameLifecycleObserver* observer : m_observers)
+ for (LocalFrameLifecycleObserver* observer : m_observers) {
+#if !ENABLE(OILPAN)
+ if (!isObserverAlive(observer))
+ continue;
+#endif
observer->willDetachFrameHost();
+ }
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698