Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: Source/core/dom/DocumentLifecycleNotifier.cpp

Issue 1132053002: [WIP]Oilpan: checking for nearly-dead observers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/DocumentLifecycleNotifier.cpp
diff --git a/Source/core/dom/DocumentLifecycleNotifier.cpp b/Source/core/dom/DocumentLifecycleNotifier.cpp
index 12fc7db522b4032cb733342f5e647fd83d44e211..44222cbab98a677742992ad6cc4fd856f12c7a4d 100644
--- a/Source/core/dom/DocumentLifecycleNotifier.cpp
+++ b/Source/core/dom/DocumentLifecycleNotifier.cpp
@@ -34,16 +34,24 @@ namespace blink {
void DocumentLifecycleNotifier::notifyDocumentWasDetached()
{
TemporaryChange<IterationType> scope(m_iterating, IteratingOverAll);
- for (DocumentLifecycleObserver* observer : m_observers)
+ for (DocumentLifecycleObserver* observer : m_observers) {
+#if !ENABLE(OILPAN)
+ if (!isObserverAlive(observer))
+ continue;
+#endif
observer->documentWasDetached();
+ }
}
#if !ENABLE(OILPAN)
void DocumentLifecycleNotifier::notifyDocumentWasDisposed()
{
TemporaryChange<IterationType> scope(m_iterating, IteratingOverAll);
- for (DocumentLifecycleObserver* observer : m_observers)
+ for (DocumentLifecycleObserver* observer : m_observers) {
+ if (!isObserverAlive(observer))
+ continue;
observer->documentWasDisposed();
+ }
}
#endif

Powered by Google App Engine
This is Rietveld 408576698