Source/platform/LifecycleContextTest.cpp - Issue 1132053002: [WIP]Oilpan: checking for nearly-dead observers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/LifecycleContextTest.cpp

Issue 1132053002: [WIP]Oilpan: checking for nearly-dead observers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/LifecycleContextTest.cpp

diff --git a/Source/platform/LifecycleContextTest.cpp b/Source/platform/LifecycleContextTest.cpp

index 883e26d8d8e8c43de2c09ea1005b071855ff62b9..ecb87ab0ddf6cc7ceb952d3d4bb43cfcaab8b1b7 100644

--- a/Source/platform/LifecycleContextTest.cpp

+++ b/Source/platform/LifecycleContextTest.cpp

@@ -63,7 +63,7 @@ public:

{

LifecycleObserver::contextDestroyed();

if (m_observerToRemoveOnDestruct) {

- lifecycleContext()->removeObserver(m_observerToRemoveOnDestruct.get());

+ lifecycleContext()->removeObserver(m_observerToRemoveOnDestruct.get(), false);

m_observerToRemoveOnDestruct.clear();

}

m_contextDestroyedCalled = true;